GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-138122: Remove default duration for statistical profiling by lkollar · Pull Request #143174 · python/cpython

Conversation

@lkollar

@lkollar lkollar commented Dec 25, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Instead of limiting profiling to 10s, let the process finish by default.

Towards #142927

  • Issue: Implement PEP 799 – A dedicated profiling package for organizing Python profiling tools #138122

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lkollar
Remove default duration
a27bd2e 
Instead of limiting profiling to 10s, let the process finish by default.
@lkollar
lkollar requested a review from pablogsal as a code owner December 25, 2025 16:22
@bedevere-app bedevere-app Bot added the awaiting review label Dec 25, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Dec 25, 2025
Implement PEP 799 – A dedicated profiling package for organizing Python profiling tools #138122
Closed
@pablogsal pablogsal added the skip news label Dec 25, 2025
@pablogsal

pablogsal commented Dec 25, 2025

Copy link
Copy Markdown
Member

I think we still need to update the docs
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Dec 25, 2025

Copy link
Copy Markdown
Member

I think sample.py still has references to duration_sec=10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
fixup! Remove default duration
a19f3ea
@pablogsal

pablogsal commented Dec 25, 2025

Copy link
Copy Markdown
Member

Pushed a small fix with the items left and a (somehow related) bug I found while testing
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal approved these changes Dec 25, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Dec 25, 2025
@pablogsal
pablogsal enabled auto-merge (squash) December 25, 2025 18:24
@pablogsal
pablogsal disabled auto-merge December 25, 2025 18:24
@pablogsal
pablogsal enabled auto-merge (squash) December 25, 2025 18:24
@picnixz picnixz changed the title gh-138122: Remove default duration gh-138122: Remove default duration for statistical profiling Dec 25, 2025
@pablogsal
pablogsal disabled auto-merge December 25, 2025 18:43
@pablogsal
Fix sampling rgument
17252ec
@pablogsal
pablogsal enabled auto-merge (squash) December 25, 2025 18:46
pablogsal added 2 commits December 25, 2025 18:48
@pablogsal
fixup! Fix sampling rgument
7ca3bb9
@pablogsal
fixup! fixup! Fix sampling rgument
07827c8
pablogsal
pablogsal approved these changes Dec 25, 2025
View reviewed changes
@pablogsal
pablogsal disabled auto-merge December 25, 2025 19:12
@pablogsal
pablogsal enabled auto-merge (squash) December 25, 2025 19:12
@pablogsal
pablogsal merged commit 888d101 into python:main Dec 25, 2025
46 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 25, 2025
@lkollar
lkollar deleted the profiling/no-default-duration branch December 25, 2025 20:06
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@lkollar @pablogsal @thunder-coding
pythongh-138122: Remove default duration for statistical profiling (p…
a989d45 
…ython#143174)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@lkollar @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.