GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-142927: Fix heatmap caller navigation for interior lines by pablogsal · Pull Request #143180 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Dec 25, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The heatmap was only showing caller buttons on function definition
lines, not on interior lines within a function. This happened because
callers were recorded against the function definition line but looked
up by the current line number when building navigation buttons.

Added a line_to_function mapping to track which function each sampled
line belongs to. When building navigation buttons, callers are now
looked up via the function definition line so all lines in a function
show who calls that function. Callees remain line-specific since only
actual call sites should show what they call. Added tests covering
root, middle, and leaf frame behavior in call stacks.

  • Issue: Improve Tachyon UX #142927

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 25, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Dec 25, 2025
Improve Tachyon UX #142927
Open
11 tasks done
@pablogsal pablogsal added the skip news label Dec 25, 2025
@pablogsal

pablogsal commented Dec 25, 2025

Copy link
Copy Markdown
Member Author

CC: @ivonastojanovic @lkollar
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal force-pushed the heatmap-fix branch from 57f1d48 to 41c5d95 Compare December 25, 2025 19:17
@pablogsal
pythongh-142927: Fix heatmap caller navigation for interior lines
b3fafc1 
The heatmap was only showing caller buttons on function definition
lines, not on interior lines within a function. This happened because
callers were recorded against the function definition line but looked
up by the current line number when building navigation buttons.

Added a line_to_function mapping to track which function each sampled
line belongs to. When building navigation buttons, callers are now
looked up via the function definition line so all lines in a function
show who calls that function. Callees remain line-specific since only
actual call sites should show what they call. Added tests covering
root, middle, and leaf frame behavior in call stacks.
@pablogsal
pablogsal force-pushed the heatmap-fix branch from 41c5d95 to b3fafc1 Compare December 25, 2025 19:19
pablogsal
pablogsal commented Dec 25, 2025
View reviewed changes
Comment thread Lib/profiling/sampling/heatmap_collector.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
Apply suggestion from @pablogsal
0742a19
@pablogsal
pablogsal merged commit 513ae17 into python:main Jan 1, 2026
44 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal deleted the heatmap-fix branch January 1, 2026 19:06
@bedevere-app bedevere-app Bot removed the awaiting core review label Jan 1, 2026
@pablogsal pablogsal added the type-bug An unexpected behavior, bug, or error label Jan 1, 2026
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@pablogsal @thunder-coding
pythongh-142927: Fix heatmap caller navigation for interior lines (py…
91ddfdd 
…thon#143180)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.