GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-143200: fix UAFs in `Element.__{set,get}item__` when the element is concurrently mutated by picnixz · Pull Request #143226 · python/cpython

Conversation

picnixz commented Dec 27, 2025 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Issue: Null pointer dereference in element_[ass_]subscr via re-entrant calls #143200

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-143200: fix UAFs in Element.__{set,get}item__

1a0c970

bedevere-app Bot added the awaiting core review label

Dec 27, 2025

bedevere-app Bot mentioned this pull request

Dec 27, 2025

Null pointer dereference in element_[ass_]subscr via re-entrant calls #143200

Closed

picnixz requested a review from serhiy-storchaka

December 27, 2025 14:43

picnixz added topic-XML needs backport to 3.13

only security fixes

needs backport to 3.14 bugs and security fixes labels

Dec 27, 2025

serhiy-storchaka reviewed

Dec 27, 2025

View reviewed changes

Comment thread

Modules/_elementtree.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Modules/_elementtree.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Modules/_elementtree.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Modules/_elementtree.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Modules/_elementtree.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Modules/_elementtree.c Resolved

Uh oh!

There was an error while loading. Please reload this page.


          address review

fbf0e29

picnixz requested a review from serhiy-storchaka

December 27, 2025 16:37


          remove debugging assertions

4509a33

serhiy-storchaka reviewed

Dec 28, 2025

View reviewed changes

Comment thread

Modules/_elementtree.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/test/test_xml_etree.py Resolved

Uh oh!

There was an error while loading. Please reload this page.


          avoid creating useless extras

b7c7f71

picnixz requested a review from serhiy-storchaka

December 28, 2025 13:23

serhiy-storchaka approved these changes

Dec 29, 2025

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting merge and removed awaiting core review labels

Dec 29, 2025

picnixz merged commit b6b0e14 into python:main

Dec 29, 2025

50 checks passed

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot commented Dec 29, 2025

Copy link

Copy Markdown

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

picnixz deleted the fix/xml/uaf-in-sub-143200 branch

December 29, 2025 17:30

bedevere-app Bot removed the awaiting merge label

Dec 29, 2025

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Dec 29, 2025


          pythongh-143200: fix UAFs in Element.__{set,get}item__ when the ele…

f3bc3a7

…ment is concurrently mutated (pythonGH-143226)

(cherry picked from commit b6b0e14)

Co-authored-by: Bénédikt Tran <[email protected]>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Dec 29, 2025


          pythongh-143200: fix UAFs in Element.__{set,get}item__ when the ele…

e02ebbd

…ment is concurrently mutated (pythonGH-143226)

(cherry picked from commit b6b0e14)

Co-authored-by: Bénédikt Tran <[email protected]>

bedevere-app Bot commented Dec 29, 2025

Copy link

Copy Markdown

GH-143273 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label

Dec 29, 2025

bedevere-app Bot commented Dec 29, 2025

Copy link

Copy Markdown

GH-143274 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label

Dec 29, 2025

picnixz added a commit that referenced this pull request

Dec 29, 2025


          [3.14] gh-143200: fix UAFs in Element.__{set,get}item__ when the el…

7ff87fa

…ement is concurrently mutated (GH-143226) (#143273)

gh-143200: fix UAFs in `Element.__{set,get}item__` when the element is concurrently mutated (GH-143226)
(cherry picked from commit b6b0e14)

Co-authored-by: Bénédikt Tran <[email protected]>

picnixz added a commit that referenced this pull request

Dec 29, 2025


          [3.13] gh-143200: fix UAFs in Element.__{set,get}item__ when the el…

93cb42f

…ement is concurrently mutated (GH-143226) (#143274)

gh-143200: fix UAFs in `Element.__{set,get}item__` when the element is concurrently mutated (GH-143226)
(cherry picked from commit b6b0e14)

Co-authored-by: Bénédikt Tran <[email protected]>

thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request

Feb 15, 2026


          pythongh-143200: fix UAFs in Element.__{set,get}item__ when the ele…

7e511ed

…ment is concurrently mutated (python#143226)

Reviewers

serhiy-storchaka

serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-XML

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

picnixz commented Dec 27, 2025 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-app Bot commented Dec 29, 2025

Uh oh!

bedevere-app Bot commented Dec 29, 2025

Uh oh!

bedevere-app Bot commented Dec 29, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

picnixz commented Dec 27, 2025 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.