GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-143237: Fix support of named pipes in the rotating logging handlers (GH-143259) by miss-islington · Pull Request #143297 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Dec 30, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This fixes regression introduced in GH-105887.
(cherry picked from commit aa8a43d)

Co-authored-by: Serhiy Storchaka [email protected]

  • Issue: logging.handler fails when attempting to rotate a fifo (with potential fix) #143237

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka @miss-islington
pythongh-143237: Fix support of named pipes in the rotating logging h…
f45b111 
…andlers (pythonGH-143259)

This fixes regression introduced in pythonGH-105887.
(cherry picked from commit aa8a43d)

Co-authored-by: Serhiy Storchaka <[email protected]>
@miss-islington
miss-islington requested a review from vsajip as a code owner December 30, 2025 14:56
@bedevere-app bedevere-app Bot mentioned this pull request Dec 30, 2025
logging.handler fails when attempting to rotate a fifo (with potential fix) #143237
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Dec 30, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Dec 30, 2025
gh-143237: Fix support of named pipes in the rotating logging handlers #143259
Merged
pablogsal
pablogsal reviewed Jan 25, 2026
View reviewed changes

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
pablogsal merged commit c9548f3 into python:3.14 Jan 25, 2026
49 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Jan 25, 2026
@miss-islington
miss-islington deleted the backport-aa8a43d-3.14 branch January 25, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal left review comments
@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @pablogsal @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.