GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-143237: Fix support of named pipes in the rotating logging handlers by serhiy-storchaka · Pull Request #143259 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Dec 28, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This fixes regression introduced in GH-105887.

  • Issue: logging.handler fails when attempting to rotate a fifo (with potential fix) #143237

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-143237: Fix support of named pipes in the rotating logging h…
cc46702 
…andlers

This fixes regression introduced in pythonGH-105887.
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.13 only security fixes label Dec 28, 2025
@serhiy-storchaka
serhiy-storchaka requested a review from vsajip as a code owner December 28, 2025 18:40
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label Dec 28, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 28, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Dec 28, 2025
logging.handler fails when attempting to rotate a fifo (with potential fix) #143237
Closed
aisk
aisk reviewed Dec 29, 2025
View reviewed changes
Comment thread Lib/test/test_logging.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 29, 2025
@bedevere-bot

bedevere-bot commented Dec 29, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit cc46702 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F143259%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 29, 2025
serhiy-storchaka added 3 commits December 30, 2025 16:13
@serhiy-storchaka
Use contextlib.closing.
9d97701
@serhiy-storchaka
Merge branch 'main' into logging-rotate-named-file
cfa5a05
@serhiy-storchaka
Test also that it works with a named pipe at all.
a9f312e
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) December 30, 2025 14:32
@serhiy-storchaka
serhiy-storchaka merged commit aa8a43d into python:main Dec 30, 2025
46 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Dec 30, 2025
@miss-islington-app

miss-islington-app Bot commented Dec 30, 2025

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 30, 2025
@serhiy-storchaka @miss-islington
pythongh-143237: Fix support of named pipes in the rotating logging h…
f45b111 
…andlers (pythonGH-143259)

This fixes regression introduced in pythonGH-105887.
(cherry picked from commit aa8a43d)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 30, 2025
@serhiy-storchaka @miss-islington
pythongh-143237: Fix support of named pipes in the rotating logging h…
6106e1f 
…andlers (pythonGH-143259)

This fixes regression introduced in pythonGH-105887.
(cherry picked from commit aa8a43d)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app

bedevere-app Bot commented Dec 30, 2025

Copy link
Copy Markdown

GH-143297 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Dec 30, 2025
@bedevere-app

bedevere-app Bot commented Dec 30, 2025

Copy link
Copy Markdown

GH-143298 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Dec 30, 2025
pablogsal pushed a commit that referenced this pull request Jan 25, 2026
@miss-islington @serhiy-storchaka
[3.13] gh-143237: Fix support of named pipes in the rotating logging …
8ad8287 
…handlers (GH-143259) (#143298)

gh-143237: Fix support of named pipes in the rotating logging handlers (GH-143259)

This fixes regression introduced in GH-105887.
(cherry picked from commit aa8a43d)

Co-authored-by: Serhiy Storchaka <[email protected]>
pablogsal pushed a commit that referenced this pull request Jan 25, 2026
@miss-islington @serhiy-storchaka
[3.14] gh-143237: Fix support of named pipes in the rotating logging …
c9548f3 
…handlers (GH-143259) (#143297)

Co-authored-by: Serhiy Storchaka <[email protected]>
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@serhiy-storchaka @thunder-coding
pythongh-143237: Fix support of named pipes in the rotating logging h…
8add574 
…andlers (pythonGH-143259)

This fixes regression introduced in pythonGH-105887.
@serhiy-storchaka
serhiy-storchaka deleted the logging-rotate-named-file branch July 1, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aisk aisk aisk left review comments
@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@serhiy-storchaka @bedevere-bot @aisk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.