GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-139757: Add _GUARD_NOS_COMPACT_ASCII for compact ascii optimization by corona10 · Pull Request #143332 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Jan 1, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Introduce _GUARD_NOS_COMPACT_ASCII for the compact ASCII optimization path.
Although this guard is potentially more expensive than _GUARD_NOS_UNICODE, it helps the optimizer exit earlier when it attempts to optimize BINARY_OP_SUBSCR_STR_INT.

  • Issue: JIT assembly optimizer leaves some redundant branches #139757

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
pythongh-139757: Add _GUARD_NOS_COMPACT_ASCII for compact ascii optim…
54af89d 
…ization
@corona10
corona10 requested review from Fidget-Spinner, markshannon and tomasr8 as code owners January 1, 2026 16:37
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 1, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jan 1, 2026
JIT assembly optimizer leaves some redundant branches #139757
Closed
@corona10 corona10 added the skip news label Jan 1, 2026
Fidget-Spinner
Fidget-Spinner reviewed Jan 1, 2026
View reviewed changes
Comment thread Python/bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/optimizer_bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@corona10
Address code review
3dafb0a
@corona10
corona10 requested a review from Fidget-Spinner January 2, 2026 00:05
@corona10
Merge remote-tracking branch 'upstream/main' into pythongh-139757-gua…
a86857d 
…rd-ascii
Fidget-Spinner
Fidget-Spinner approved these changes Jan 2, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jan 2, 2026
@corona10
corona10 merged commit 315f474 into python:main Jan 2, 2026
72 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 2, 2026
@corona10
corona10 deleted the gh-139757-guard-ascii branch January 2, 2026 11:58
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@corona10 @thunder-coding
pythongh-139757: Add _GUARD_NOS_COMPACT_ASCII for compact ascii optim…
9438b06 
…ization (pythongh-143332)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@tomasr8 tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@corona10 @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.