GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-142927: Hide _sync_coordinator frames from profiler output by pablogsal · Pull Request #143337 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Jan 1, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

When running scripts via "python -m profiling.sampling run", the internal
_sync_coordinator module appears in stack traces between runpy and user
code. These frames are implementation details that clutter the output and
provide no useful information to users analyzing their program's behavior.

The fix adds a filter_internal_frames function that removes frames from
_sync_coordinator.py anywhere in the call stack. This is applied in both
the base Collector._iter_all_frames method and directly in GeckoCollector
which bypasses the iterator. Tests cover all collector types: pstats,
flamegraph, collapsed stack, and gecko formats.

  • Issue: Improve Tachyon UX #142927

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 1, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jan 1, 2026
Improve Tachyon UX #142927
Open
11 tasks done
@pablogsal pablogsal added type-bug An unexpected behavior, bug, or error skip news and removed awaiting core review labels Jan 1, 2026
@pablogsal
pablogsal requested a review from ivonastojanovic January 1, 2026 21:24
@pablogsal

pablogsal commented Jan 1, 2026

Copy link
Copy Markdown
Member Author

@lkollar

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal
pythongh-142927: Hide _sync_coordinator frames from profiler output
0629b78
When running scripts via "python -m profiling.sampling run", the internal
_sync_coordinator module appears in stack traces between runpy and user
code. These frames are implementation details that clutter the output and
provide no useful information to users analyzing their program's behavior.

The fix adds a filter_internal_frames function that removes frames from
_sync_coordinator.py anywhere in the call stack. This is applied in both
the base Collector._iter_all_frames method and directly in GeckoCollector
which bypasses the iterator. Tests cover all collector types: pstats,
flamegraph, collapsed stack, and gecko formats.
@pablogsal
pablogsal force-pushed the hide branch from 5d2771d to 0629b78 Compare January 1, 2026 21:26
@picnixz picnixz added awaiting core review and removed type-bug An unexpected behavior, bug, or error labels Jan 1, 2026
ivonastojanovic
ivonastojanovic approved these changes Jan 2, 2026
View reviewed changes

@ivonastojanovic ivonastojanovic left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@pablogsal
pablogsal merged commit 09ce592 into python:main Jan 2, 2026
48 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal
pablogsal deleted the hide branch January 2, 2026 12:09
@bedevere-app bedevere-app Bot removed the awaiting core review label Jan 2, 2026
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@pablogsal @thunder-coding
pythongh-142927: Hide _sync_coordinator frames from profiler output (p…
a0842e4
…ython#143337)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivonastojanovic ivonastojanovic ivonastojanovic approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@pablogsal @ivonastojanovic @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.