GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-143346: Fix calculation of the line width for wrapped Base64 in plistlib by serhiy-storchaka · Pull Request #143347 · python/cpython

Conversation

serhiy-storchaka commented Jan 2, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

It was incorrect in case of mixed tabs and spaces in indentation.

Issue: Incorrect calculation of indentation width in case of mixed tabs and spaces in plistlib #143346

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added the awaiting core review label

Jan 2, 2026

bedevere-app Bot mentioned this pull request

Jan 2, 2026

Incorrect calculation of indentation width in case of mixed tabs and spaces in plistlib #143346

Closed

serhiy-storchaka commented

Jan 2, 2026

View reviewed changes

Comment thread

Lib/test/test_plistlib.py

		b'</array>\n'
		b'</plist>\n')

		pl = dumps_with_indent(data, b' \t')

serhiy-storchaka Jan 2, 2026

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This catches the original bug.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/test/test_plistlib.py

		b'</array>\n'
		b'</plist>\n')

		pl = dumps_with_indent(data, b'\t ')

serhiy-storchaka Jan 2, 2026

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This catches a bug in my initial fix in #143216.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/test/test_plistlib.py

		writer.write(data)
		return fp.getvalue()

		pl = dumps_with_indent(data, b' ')

serhiy-storchaka Jan 2, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests non-default indentation.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

serhiy-storchaka requested a review from ronaldoussoren

January 2, 2026 11:01

serhiy-storchaka added needs backport to 3.13

only security fixes

needs backport to 3.14 bugs and security fixes labels

Jan 2, 2026


          pythongh-143346: Fix calculation of the line width for wrapped Base64…

389a103

… in plistlib

It was incorrect in case of mixed tabs and spaces in indentation.

serhiy-storchaka force-pushed the plistlib-base64-indent branch from 5be5810 to 389a103 Compare

January 2, 2026 11:30

serhiy-storchaka merged commit 5f28aa2 into python:main

Jan 12, 2026

46 checks passed

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting core review label

Jan 12, 2026

miss-islington-app Bot commented Jan 12, 2026

Copy link

Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka deleted the plistlib-base64-indent branch

January 12, 2026 08:40

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jan 12, 2026


          pythongh-143346: Fix calculation of the line width for wrapped Base64…

2fe821c

… in plistlib (pythonGH-143347)

It was incorrect in case of mixed tabs and spaces in indentation.
(cherry picked from commit 5f28aa2)

Co-authored-by: Serhiy Storchaka <[email protected]>

bedevere-app Bot commented Jan 12, 2026

Copy link

Copy Markdown

GH-143719 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label

Jan 12, 2026

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jan 12, 2026


          pythongh-143346: Fix calculation of the line width for wrapped Base64…

77fc4e5

… in plistlib (pythonGH-143347)

It was incorrect in case of mixed tabs and spaces in indentation.
(cherry picked from commit 5f28aa2)

Co-authored-by: Serhiy Storchaka <[email protected]>

bedevere-app Bot commented Jan 12, 2026

Copy link

Copy Markdown

GH-143720 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label

Jan 12, 2026

serhiy-storchaka added a commit that referenced this pull request

Jan 12, 2026


          [3.13] gh-143346: Fix calculation of the line width for wrapped Base6…

8ec1083

…4 in plistlib (GH-143347) (GH-143720)

It was incorrect in case of mixed tabs and spaces in indentation.
(cherry picked from commit 5f28aa2)

Co-authored-by: Serhiy Storchaka <[email protected]>

serhiy-storchaka added a commit that referenced this pull request

Jan 12, 2026


          [3.14] gh-143346: Fix calculation of the line width for wrapped Base6…

6447fa3

…4 in plistlib (GH-143347) (GH-143719)

It was incorrect in case of mixed tabs and spaces in indentation.
(cherry picked from commit 5f28aa2)

Co-authored-by: Serhiy Storchaka <[email protected]>

reidenong pushed a commit to reidenong/cpython that referenced this pull request

Jan 12, 2026


          pythongh-143346: Fix calculation of the line width for wrapped Base64…

b7af241

… in plistlib (pythonGH-143347)

It was incorrect in case of mixed tabs and spaces in indentation.

thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request

Feb 15, 2026


          pythongh-143346: Fix calculation of the line width for wrapped Base64…

d386775

… in plistlib (pythonGH-143347)

It was incorrect in case of mixed tabs and spaces in indentation.

Reviewers

ronaldoussoren

Awaiting requested review from ronaldoussoren

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

serhiy-storchaka commented Jan 2, 2026 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

serhiy-storchaka Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-app Bot commented Jan 12, 2026

Uh oh!

bedevere-app Bot commented Jan 12, 2026

Uh oh!

bedevere-app Bot commented Jan 12, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

serhiy-storchaka commented Jan 2, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka Jan 2, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.