GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-143531: Use macro to check if PEP 523 is hooked by DinoV · Pull Request #143532 · python/cpython

Conversation

@DinoV

@DinoV DinoV commented Jan 7, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This just moves the checks to see if PEP-523 is replaced to a common macro in the interpreter loop.

This will allow PEP 523 users who re-generate the interpreter loop (as in #142911) to redefine the macro to support their replacement with the optimizer as well if they so choose. And it makes it more explicit what these checks are doing when they're randomly sprinkled around.

  • Issue: Minor issues prevent compatibility regen'd interpreter loop #143531

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@DinoV
Use macro to check if PEP 523 is hooked
7cebe3e
@DinoV DinoV added the skip news label Jan 7, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jan 7, 2026
Minor issues prevent compatibility regen'd interpreter loop #143531
Closed
@DinoV
DinoV requested review from Fidget-Spinner and brandtbucher January 7, 2026 20:44
Fidget-Spinner
Fidget-Spinner approved these changes Jan 7, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added the awaiting merge label Jan 7, 2026
@DinoV
DinoV marked this pull request as ready for review January 7, 2026 21:25
@DinoV
DinoV requested a review from markshannon as a code owner January 7, 2026 21:25
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting merge labels Jan 7, 2026
@DinoV
DinoV merged commit bfc3d8d into python:main Jan 7, 2026
76 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Jan 7, 2026
meta-codesync Bot pushed a commit to facebookincubator/cinderx that referenced this pull request Jan 8, 2026
@DinoV @meta-codesync
Remove copied opcodes now that we have better upstream support
37179d1 
Summary:
On yesterday imports we hit some issues with one of the opcodes we've duplicated. We duplicated it so that we could support optimized python -> python calls when we have our eval hook in place.

I landed python/cpython#143532 yesterday which makes it possible for us to just redefine the `IS_PEP523_HOOKED` macro. This macro conveniently already defined in our copy of `ceval_macros.h` so the upgrade to consume this is just deleting our overloaded opcodes and picking up the base ones.

Reviewed By: jbower-fb

Differential Revision: D90279669

fbshipit-source-id: ecc4d87981554aa5a5bf9f27519622cf17cfe2ed
reidenong pushed a commit to reidenong/cpython that referenced this pull request Jan 12, 2026
@DinoV @reidenong
pythongh-143531: Use macro to check if PEP 523 is hooked (python#143532)
97d6e8d 
Use macro to check if PEP 523 is hooked
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@DinoV @thunder-coding
pythongh-143531: Use macro to check if PEP 523 is hooked (python#143532)
3d344c7 
Use macro to check if PEP 523 is hooked
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@brandtbucher brandtbucher Awaiting requested review from brandtbucher
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@DinoV @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.