GeezerVison

Original file line number	Diff line number	Diff line change
Expand Up		@@ -229,6 +229,10 @@ def get_frees(self):
		self.__frees = self.__idents_matching(is_free)
		return self.__frees

		def get_cells(self):
		"""Return a list of cell variable names in the table."""
		return [s.get_name() for s in self.get_symbols() if s.is_cell()]
Comment thread Outdated iritkatriel Jan 21, 2026 Copy link Copy Markdown Member There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Why does this not follow the pattern of get_frees and get_nonlocals? Sorry, something went wrong. Uh oh! There was an error while loading. Please reload this page. All reactions Yashp002 Jan 21, 2026 Copy link Copy Markdown Contributor Author There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. We'll have to use the _cells variable then, I'll add it. Sorry, something went wrong. Uh oh! There was an error while loading. Please reload this page. All reactions

Comment thread Yashp002 marked this conversation as resolved. Resolved Uh oh! There was an error while loading. Please reload this page.

		class Class(SymbolTable):

Expand Down Expand Up		@@ -342,6 +346,10 @@ def is_free(self):
		"""
		return bool(self.__scope == FREE)

		def is_cell(self):
		"""Return True if the symbol is a cell variable."""
		return bool(self.__scope == CELL)

		def is_free_class(self):
		"""Return True if a class-scoped symbol is free from
		the perspective of a method."""
Expand Down

14 changes: 14 additions & 0 deletions 14 Lib/test/test_symtable.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -284,6 +284,20 @@ def test_local(self):
		def test_free(self):
		self.assertTrue(self.internal.lookup("x").is_free())

		def test_cells(self):
		#test for addition of is_cell() and get_cells()
		#see https://github.com/python/cpython/issues/143504
		code="""def outer():
		x=1
		def inner():
		return x"""
Comment thread Outdated iritkatriel Jan 21, 2026 Copy link Copy Markdown Member There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. the other tests don't do all this. Can we follow the same pattern in this one? Sorry, something went wrong. Uh oh! There was an error while loading. Please reload this page. All reactions Yashp002 Jan 21, 2026 Copy link Copy Markdown Contributor Author There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. @iritkatriel I've implemented the change in symtable.py with get_cells But the current test_cells seems to be the only one that keeps working after I've change it up quite a few times. Is it really a requirement for it all to have the same pattern? Sorry, something went wrong. Uh oh! There was an error while loading. Please reload this page. All reactions iritkatriel Jan 21, 2026 Copy link Copy Markdown Member There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Unless there's a reason why we can't, then we should follow the same pattern. What's the difference between the cases? Sorry, something went wrong. Uh oh! There was an error while loading. Please reload this page. All reactions Yashp002 Jan 22, 2026 Copy link Copy Markdown Contributor Author There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. self.internal has x as FREE var (for test_free). we need x as CELL var (outer scope). setUp doesn't have that so inline code is needed. However I've removed the unnecessary comments and changed the rest of it to `top=symtable.symtable(code,"?","exec") outer = find_block(top, "outer") self.assertEqual(outer.get_cells(), ["x"]) self.assertTrue(outer.lookup("x").is_cell()) self.assertFalse(outer.lookup("inner").is_cell()) to use assert.Equal,true and false like the rest of the functions. WOuld this be satisfactory as a commit?` Sorry, something went wrong. Uh oh! There was an error while loading. Please reload this page. All reactions iritkatriel Jan 23, 2026 Copy link Copy Markdown Member There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. self.spam.lookup("x").is_cell() Sorry, something went wrong. Uh oh! There was an error while loading. Please reload this page. All reactions iritkatriel Jan 23, 2026 Copy link Copy Markdown Member There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. and get_cells test should be next to get_frees test. Sorry, something went wrong. Uh oh! There was an error while loading. Please reload this page. All reactions Yashp002 Jan 23, 2026 Copy link Copy Markdown Contributor Author There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. and get_cells test should be next to get_frees test. isn't test_cells already next to test_free? Sorry, something went wrong. Uh oh! There was an error while loading. Please reload this page. All reactions

		top=symtable.symtable(code,"?","exec")
		outer = find_block(top, "outer")
		self.assertIn("x",outer.get_cells())
		self.assertTrue(outer.lookup("x").is_cell())
		self.assertFalse(outer.lookup("inner").is_cell())

Comment thread Outdated iritkatriel Jan 23, 2026 Copy link Copy Markdown Member There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. get_cells is not tested at all. Sorry, something went wrong. Uh oh! There was an error while loading. Please reload this page. All reactions iritkatriel Jan 23, 2026 Copy link Copy Markdown Member There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Add it to test_function_info: `@@ -255,6 +255,7 @@ def test_function_info(self): self.assertEqual(sorted(func.get_locals()), expected) self.assertEqual(sorted(func.get_globals()), ["bar", "glob", "some_assigned_global_var"]) self.assertEqual(self.internal.get_frees(), ("x",)) + self.assertEqual(self.spam.get_cells(), ("some_var", "x",))` Sorry, something went wrong. Uh oh! There was an error while loading. Please reload this page. All reactions Comment thread Yashp002 marked this conversation as resolved. Resolved Uh oh! There was an error while loading. Please reload this page.
		def test_referenced(self):
		self.assertTrue(self.internal.lookup("x").is_referenced())
		self.assertTrue(self.spam.lookup("internal").is_referenced())
Expand Down

1 change: 1 addition & 0 deletions 1 Misc/NEWS.d/next/Core_and_Builtins/2026-01-08-16-28-03.gh-issue-143504.PlC_Yv.rst

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Add symtable.is_cell() and get_cells() methods for cell variable analysis.
Comment thread Outdated iritkatriel Jan 24, 2026 Copy link Copy Markdown Member There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. There are two News files now Sorry, something went wrong. Uh oh! There was an error while loading. Please reload this page. All reactions

Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

gh-143504: Expose CELL status of a symbol in symtable #143549

Uh oh!

gh-143504: Expose CELL status of a symbol in symtable #143549

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!