GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add Emscripten test skips for recently added tests. by freakboy3742 · Pull Request #143551 · python/cpython

Conversation

@freakboy3742

@freakboy3742 freakboy3742 commented Jan 8, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Some minor changes to some tests that recently started failing on Emscripten:

  • Tests from gh-135953: Add GIL contention markers to sampling profiler Gecko format #139485 that can't run on Emscripten because of the lack of threads
  • A tweak to how free-threading is detected in the profiler tests, matching other usages (because an environment variable value of Py_GIL_DISABLED=0 shouldn't be interpreted as "GIL disabled") Not sure what is going on with this one, but it caused all the Windows and Ubuntu tests to fail.
  • A test that now fails as a result of a change made by Implement stack overflow protection for linux based on actual stack depth #130396

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@freakboy3742
Add Emscripten test skips for recently added tests.
1118f6f
@freakboy3742
freakboy3742 requested a review from hoodmane January 8, 2026 08:12
@freakboy3742
freakboy3742 requested a review from pablogsal as a code owner January 8, 2026 08:12
@freakboy3742 freakboy3742 added skip issue skip news OS-emscripten labels Jan 8, 2026
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 8, 2026
@freakboy3742

freakboy3742 commented Jan 8, 2026

Copy link
Copy Markdown
Contributor Author

!buildbot emscripten
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jan 8, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 1118f6f 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F143551%2Fmerge

The command will test the builders whose names match following regular expression: emscripten

The builders matched are:

  • WASM Emscripten PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@freakboy3742
Revert sysconfig freethreading check.
9c4d800
@freakboy3742

freakboy3742 commented Jan 8, 2026

Copy link
Copy Markdown
Contributor Author

!buildbot emscripten
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jan 8, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 9c4d800 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F143551%2Fmerge

The command will test the builders whose names match following regular expression: emscripten

The builders matched are:

  • WASM Emscripten PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Jan 8, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I didn't test the change, I just read the code changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jan 8, 2026
hoodmane
hoodmane approved these changes Jan 8, 2026
View reviewed changes

@hoodmane hoodmane left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @freakboy3742 !

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@freakboy3742
freakboy3742 merged commit b54a1d2 into python:main Jan 8, 2026
49 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@freakboy3742
freakboy3742 deleted the emscripten-tests branch January 8, 2026 21:47
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 8, 2026
reidenong pushed a commit to reidenong/cpython that referenced this pull request Jan 12, 2026
@freakboy3742 @reidenong
Add Emscripten test skips for recently added tests. (python#143551)
6b78a3e 
Some recent changes introduced tests that can't run on Emscripten.
This change adds test skips for those tests.
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@freakboy3742 @thunder-coding
Add Emscripten test skips for recently added tests. (python#143551)
2066bbb 
Some recent changes introduced tests that can't run on Emscripten.
This change adds test skips for those tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@hoodmane hoodmane hoodmane approved these changes
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OS-emscripten skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@freakboy3742 @bedevere-bot @vstinner @hoodmane
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.