GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-143421: Use new buffer to save optimized uops by cocolato · Pull Request #143682 · python/cpython

Conversation

@cocolato

@cocolato cocolato commented Jan 11, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: JIT optimizer cleanups #143421

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cocolato
use add_op to save optimized uops
e771fd0
@cocolato
cocolato requested review from Fidget-Spinner, markshannon and tomasr8 as code owners January 11, 2026 08:43
@python-cla-bot

python-cla-bot Bot commented Jan 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the awaiting review label Jan 11, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jan 11, 2026
JIT optimizer cleanups #143421
Closed
@cocolato

cocolato commented Jan 11, 2026

Copy link
Copy Markdown
Member Author

@Fidget-Spinner There may be many details that need fixing, and I hope you can give me some suggestions.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cocolato

cocolato commented Jan 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

I haven't yet removed the cases of REPLACE_OP((inst+1),...), perhaps there's a better way to achieve this.

cpython/Python/optimizer_analysis.c

Line 244 in 03e6457

REPLACE_OP((this_instr+1), _EXIT_TRACE, 0, 0);

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Fidget-Spinner
Fidget-Spinner reviewed Jan 11, 2026
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is really valuable work. We definitely need this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Python/optimizer_analysis.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/optimizer_analysis.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Include/internal/pycore_optimizer_types.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/optimizer_analysis.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/optimizer_bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/optimizer_analysis.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@cocolato

cocolato commented Jan 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Thanks for taking the time to review this! I will rewrite them later.
Fidget-Spinner reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cocolato
optimize code struct
4a0db15
@cocolato
cocolato requested a review from ericsnowcurrently as a code owner January 11, 2026 17:42
@cocolato
optimize code struct
25797cf
@Fidget-Spinner Fidget-Spinner added the skip news label Jan 12, 2026
cocolato and others added 3 commits January 12, 2026 21:32
@cocolato
Merge branch 'main' into feat/ADD_OP
618cb4f
@cocolato
regen cases
57a22e9
@cocolato
optimize code
031d6e3
Fidget-Spinner
Fidget-Spinner reviewed Jan 12, 2026
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite close.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Include/internal/pycore_tstate.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Include/internal/pycore_optimizer_types.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@cocolato
remove out_len
45f8ce0
@cocolato

cocolato commented Jan 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Updated, thanks for your patient guidance!
Fidget-Spinner reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cocolato and others added 3 commits January 13, 2026 01:42
@cocolato
Merge branch 'main' into feat/ADD_OP
2969891
@cocolato
regen cases
0d07c5b
@cocolato
move out_len to JitOptContext
15f32b9
Fidget-Spinner
Fidget-Spinner reviewed Jan 12, 2026
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, last few minor comments. then I think this is ready to merge.

Thank you for your patience in enduring my comments :).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cocolato reacted with heart emoji
All reactions
  • ❤️ 1 reaction
Comment thread Python/optimizer_analysis.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/optimizer_analysis.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/optimizer_analysis.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@cocolato
remove cur_len
543971c
@cocolato

cocolato commented Jan 12, 2026

Copy link
Copy Markdown
Member Author

I may have misunderstood the previous comment. Thank you again for your guidance!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner

Fidget-Spinner commented Jan 12, 2026

Copy link
Copy Markdown
Member

Will leave this open for three days in case any other people want to review.
cocolato reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cocolato
Merge branch 'main' into feat/ADD_OP
184196e
@cocolato
cocolato requested a review from savannahostrowski as a code owner January 17, 2026 14:08
@cocolato
cocolato requested a review from Fidget-Spinner January 17, 2026 14:44
@Fidget-Spinner
Fidget-Spinner merged commit b4b7324 into python:main Jan 17, 2026
72 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Jan 17, 2026
@Fidget-Spinner

Fidget-Spinner commented Jan 17, 2026

Copy link
Copy Markdown
Member

Thanks!
cocolato reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cocolato
cocolato deleted the feat/ADD_OP branch January 20, 2026 14:13
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@cocolato @thunder-coding
pythongh-143421: Use new buffer to save optimized uops (pythonGH-143682)
f8ace70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@tomasr8 tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@cocolato @Fidget-Spinner @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.