GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-131798: JIT optimizer: Support custom binary op and property frames by Fidget-Spinner · Pull Request #143735 · python/cpython

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Jan 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

BINARY_OP_SUBSCR_INIT_FRAME is the opcode for subscripting custom __getitem__.

LOAD_ATTR_PROPERTY is the opcode for loading an attribute decorated with @property.

I see a solid 0.5-1% speedup from this PR alone on Sam's fastmark (pyperformance subset).

  • Issue: Better uop coverage in the JIT optimizer #131798

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Fidget-Spinner
JIT: Support custom binary op and property frames
a9c244a
@Fidget-Spinner
Fidget-Spinner requested review from markshannon and tomasr8 as code owners January 12, 2026 16:41
@Fidget-Spinner Fidget-Spinner added the skip news label Jan 12, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jan 12, 2026
Better uop coverage in the JIT optimizer #131798
Open
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 12, 2026
@Fidget-Spinner Fidget-Spinner changed the title gh-131798: JIT: Support custom binary op and property frames gh-131798: JIT optimizer: Support custom binary op and property frames Jan 12, 2026
@Fidget-Spinner
Merge remote-tracking branch 'upstream/main' into last_few_push_frames
5514f48
@savannahostrowski
savannahostrowski self-requested a review January 13, 2026 04:25
savannahostrowski
savannahostrowski requested changes Jan 13, 2026
View reviewed changes
Comment thread Lib/test/test_capi/test_opt.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/optimizer_bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_capi/test_opt.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/optimizer_bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting changes and removed awaiting core review labels Jan 13, 2026
@bedevere-app

bedevere-app Bot commented Jan 13, 2026

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner
Address code review
0f3e071
@Fidget-Spinner
Fidget-Spinner requested a review from savannahostrowski January 13, 2026 08:48
savannahostrowski
savannahostrowski approved these changes Jan 13, 2026
View reviewed changes

@savannahostrowski savannahostrowski left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting changes labels Jan 13, 2026
@Fidget-Spinner
Fidget-Spinner merged commit 2873c31 into python:main Jan 13, 2026
65 of 66 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 13, 2026
@Fidget-Spinner
Fidget-Spinner deleted the last_few_push_frames branch January 13, 2026 19:11
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@Fidget-Spinner @thunder-coding
pythongh-131798: JIT optimizer: Support custom binary op and property…
7bffd69 
… frames (pythonGH-143735)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@savannahostrowski savannahostrowski savannahostrowski approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@tomasr8 tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Fidget-Spinner @savannahostrowski
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.