GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-143672: Finish conversion of the struct module to Argument Clinic by serhiy-storchaka · Pull Request #143857 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jan 15, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Finish conversion of the struct module to Argument Clinic #143856
  • Issue: Convert the struct module to use the Argument Clinic #143672

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-143856: Finish conversion of the struct module to Argument C…
0c00367 
…linic
@serhiy-storchaka
serhiy-storchaka requested a review from skirpichev January 15, 2026 08:30
@serhiy-storchaka serhiy-storchaka added the skip news label Jan 15, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jan 15, 2026
Finish conversion of the struct module to Argument Clinic #143856
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 15, 2026
@serhiy-storchaka serhiy-storchaka changed the title gh-143856: Finish conversion of the struct module to Argument Clinic gh-143672: Finish conversion of the struct module to Argument Clinic Jan 15, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jan 15, 2026
Convert the struct module to use the Argument Clinic #143672
Closed
@serhiy-storchaka
Merge branch 'main' into struct-clinic
5bee0ac
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jan 15, 2026
gh-143672: convert the struct module to AC #143673
Closed
skirpichev
skirpichev reviewed Jan 15, 2026
View reviewed changes
Comment thread Modules/_struct.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_struct.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
skirpichev
skirpichev requested changes Jan 16, 2026
View reviewed changes
Comment thread Modules/_struct.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_struct.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka @skirpichev
Re-wrap docstrings and minor clean up.
515ba46 
Co-authored-by: Sergey B Kirpichev <[email protected]>
serhiy-storchaka
serhiy-storchaka commented Jan 16, 2026
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated docstrings. Please look if I missed something.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/_struct.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
skirpichev
skirpichev approved these changes Jan 16, 2026
View reviewed changes
skirpichev
skirpichev reviewed Jan 16, 2026
View reviewed changes
Comment thread Modules/_struct.c
Struct.pack_into

buffer: Py_buffer(accept={rwbuffer})
offset as offset_obj: object

@skirpichev skirpichev Jan 16, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should deprecate IndexError. OverflowError will be more meaningful here for, well, an overflow condition.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@serhiy-storchaka
serhiy-storchaka merged commit 780e969 into python:main Jan 16, 2026
45 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Jan 16, 2026
@serhiy-storchaka
serhiy-storchaka deleted the struct-clinic branch January 16, 2026 11:35
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@serhiy-storchaka @skirpichev @thunder-coding
pythongh-143672: Finish conversion of the struct module to Argument C…
87d41e1 
…linic (pythonGH-143857)

Co-authored-by: Sergey B Kirpichev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skirpichev skirpichev skirpichev approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@serhiy-storchaka @skirpichev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.