GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-143886: Ensure function annotations are returned in order of definition by pR0Ps · Pull Request #143888 · python/cpython

Conversation

@pR0Ps

@pR0Ps pR0Ps commented Jan 15, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Previously, when getting type annotations of a function, normal arguments were returned before positional-only ones in the dictionary. Since functools.singledispatch relies on this ordering being correct to dispatch based on the type of the first argument, this issue was causing incorrect registrations for functions with positional-only arguments.

This PR updates how annotations are generated so that positional-only arguments are generated and added to the dictionary before normal arguments.

  • Issue: functools.singledispatch registration prioritizes the types of normal arguments before positional-only ones #143886

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pR0Ps
pR0Ps requested review from AlexWaygood, JelleZijlstra, iritkatriel, markshannon and rhettinger as code owners January 15, 2026 18:59
@bedevere-app bedevere-app Bot mentioned this pull request Jan 15, 2026
functools.singledispatch registration prioritizes the types of normal arguments before positional-only ones #143886
Open
@bedevere-app bedevere-app Bot added the awaiting review label Jan 15, 2026
@johnslavik johnslavik mentioned this pull request Jan 20, 2026
gh-84644: Fix singledispatch annotation parsing #143465
Merged
@pR0Ps
Ensure function annotations are returned in order of definition
f709913 
Previously, when getting type annotations of a function, normal
arguments were returned before positional-only ones in the dictionary.
Since `functools.singledispatch` relies on this ordering being correct
to dispatch based on the type of the first argument, this issue was
causing incorrect registrations for functions with positional-only
arguments.

This commit updates how annotations are generated so that
positional-only arguments are generated and added to the dictionary
before normal arguments.
@pR0Ps
pR0Ps force-pushed the bugfix/annotations-order branch from 31d6239 to f709913 Compare April 15, 2026 12:55
@JelleZijlstra
JelleZijlstra merged commit cb339d3 into python:main Apr 15, 2026
54 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Apr 15, 2026
@pR0Ps
pR0Ps deleted the bugfix/annotations-order branch April 15, 2026 13:46
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@pR0Ps @ljfp
pythongh-143886: Ensure function annotations are returned in order of…
981f14d 
… definition (python#143888)

Ensure function annotations are returned in order of definition

Previously, when getting type annotations of a function, normal
arguments were returned before positional-only ones in the dictionary.
Since `functools.singledispatch` relies on this ordering being correct
to dispatch based on the type of the first argument, this issue was
causing incorrect registrations for functions with positional-only
arguments.

This commit updates how annotations are generated so that
positional-only arguments are generated and added to the dictionary
before normal arguments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@pR0Ps @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.