GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-143916: Reject control characters in wsgiref.headers.Headers (GH-143917) by gpshead · Pull Request #143973 · python/cpython

Conversation

@gpshead

@gpshead gpshead commented Jan 17, 2026

Copy link
Copy Markdown
Member
  • Add 'test.support' fixture for C0 control characters
  • Reject control characters in wsgiref.headers.Headers #143916: Reject control characters in wsgiref.headers.Headers

(cherry picked from commit f7fceed)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sethmlarson @gpshead
pythongh-143916: Reject control characters in wsgiref.headers.Headers (…
dd05b44 
…pythonGH-143917)

* Add 'test.support' fixture for C0 control characters
* pythongh-143916: Reject control characters in wsgiref.headers.Headers

(cherry picked from commit f7fceed)
@gpshead gpshead added needs backport to 3.10 needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jan 17, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jan 17, 2026
Reject control characters in wsgiref.headers.Headers #143916
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 17, 2026
@gpshead gpshead mentioned this pull request Jan 17, 2026
gh-143916: Reject control characters in wsgiref.headers.Headers #143917
Merged
@gpshead gpshead changed the title [3.13] gh-143916: Reject control characters in wsgiref.headers.Headers [3.13] gh-143916: Reject control characters in wsgiref.headers.Headers (GH-143917) Jan 17, 2026
@bedevere-app bedevere-app Bot added the type-security A security issue label Jan 17, 2026
@gpshead
gpshead enabled auto-merge (squash) January 17, 2026 18:04
@gpshead
gpshead merged commit 22e4d55 into python:3.13 Jan 17, 2026
45 of 46 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jan 17, 2026

Copy link
Copy Markdown

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Jan 17, 2026
@miss-islington-app

miss-islington-app Bot commented Jan 17, 2026

Copy link
Copy Markdown

Sorry, @gpshead, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 22e4d55285cee52bc4dbe061324e5f30bd4dee58 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned gpshead Jan 17, 2026
@miss-islington-app

miss-islington-app Bot commented Jan 17, 2026

Copy link
Copy Markdown

Sorry, @gpshead, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 22e4d55285cee52bc4dbe061324e5f30bd4dee58 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jan 17, 2026

Copy link
Copy Markdown

Sorry, @gpshead, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 22e4d55285cee52bc4dbe061324e5f30bd4dee58 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Jan 17, 2026

Copy link
Copy Markdown

GH-143974 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 17, 2026
gpshead added a commit to gpshead/cpython that referenced this pull request Jan 17, 2026
@gpshead @sethmlarson
[3.12] pythongh-143916: Reject control characters in wsgiref.headers.…
03a7342 
…Headers (pythonGH-143917) (pythonGH-143973)

pythongh-143916: Reject control characters in wsgiref.headers.Headers  (pythonGH-143917)

* Add 'test.support' fixture for C0 control characters
* pythongh-143916: Reject control characters in wsgiref.headers.Headers

(cherry picked from commit f7fceed)
(cherry picked from commit 22e4d55)

Co-authored-by: Gregory P. Smith <[email protected]>
Co-authored-by: Seth Michael Larson <[email protected]>
gpshead added a commit to gpshead/cpython that referenced this pull request Jan 17, 2026
@gpshead @sethmlarson
[3.11] pythongh-143916: Reject control characters in wsgiref.headers.…
2c84d78 
…Headers (pythonGH-143917) (pythonGH-143973)

pythongh-143916: Reject control characters in wsgiref.headers.Headers  (pythonGH-143917)

* Add 'test.support' fixture for C0 control characters
* pythongh-143916: Reject control characters in wsgiref.headers.Headers

(cherry picked from commit f7fceed)
(cherry picked from commit 22e4d55)

Co-authored-by: Gregory P. Smith <[email protected]>
Co-authored-by: Seth Michael Larson <[email protected]>
@bedevere-app

bedevere-app Bot commented Jan 17, 2026

Copy link
Copy Markdown

GH-143975 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Jan 17, 2026
gpshead added a commit to gpshead/cpython that referenced this pull request Jan 17, 2026
@gpshead @sethmlarson
[3.10] pythongh-143916: Reject control characters in wsgiref.headers.…
123bfbb 
…Headers (pythonGH-143917) (pythonGH-143973)

pythongh-143916: Reject control characters in wsgiref.headers.Headers  (pythonGH-143917)

* Add 'test.support' fixture for C0 control characters
* pythongh-143916: Reject control characters in wsgiref.headers.Headers

(cherry picked from commit f7fceed)
(cherry picked from commit 22e4d55)

Co-authored-by: Gregory P. Smith <[email protected]>
Co-authored-by: Seth Michael Larson <[email protected]>
@bedevere-app

bedevere-app Bot commented Jan 17, 2026

Copy link
Copy Markdown

GH-143976 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.10 label Jan 17, 2026
Yhg1s pushed a commit that referenced this pull request Jan 19, 2026
@gpshead @sethmlarson
[3.12] gh-143916: Reject control characters in wsgiref.headers.Headers (
4802b96 
GH-143917) (GH-143973) (#143974)

* Add 'test.support' fixture for C0 control characters
* gh-143916: Reject control characters in wsgiref.headers.Headers

(cherry picked from commit f7fceed)
(cherry picked from commit 22e4d55)

Co-authored-by: Seth Michael Larson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@gpshead @sethmlarson
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.