GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102809: No longer mention `Misc/gdbinit` in the code by johnslavik · Pull Request #143980 · python/cpython

Conversation

@johnslavik

@johnslavik johnslavik commented Jan 18, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Misc/gdbinit was removed in GH-102854 (3.12.0a7).

  • Issue: What to do with Misc/gdbinit? #102809

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@johnslavik
Fix misleading comment on PyObject_Dump
3e958f6
@johnslavik johnslavik added the skip issue label Jan 18, 2026
@johnslavik
johnslavik requested a review from ZeroIntensity as a code owner January 18, 2026 01:50
@johnslavik johnslavik added skip news needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Jan 18, 2026
@bedevere-app bedevere-app Bot added the awaiting review label Jan 18, 2026
@johnslavik johnslavik changed the title No longer mention Misc/gdbinit in PyObject_Dump code doc No longer mention Misc/gdbinit in the code Jan 18, 2026
StanFromIreland
StanFromIreland reviewed Jan 18, 2026
View reviewed changes

@StanFromIreland StanFromIreland left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or fix it like this one was done?

cpython/Doc/howto/gdb_helpers.rst

Line 40 in 63cc125

- GDB 7 or later. (For earlier versions of GDB, see ``Misc/gdbinit`` in the

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@johnslavik

johnslavik commented Jan 18, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Or fix it like this one was done?

cpython/Doc/howto/gdb_helpers.rst

Line 40 in 63cc125

- GDB 7 or later. (For earlier versions of GDB, see ``Misc/gdbinit`` in the

I'm not sure. This comment remains on 3.10, 3.11 and 3.12 branches, would including Misc/gdbinit again be helpful?
Or do you mean mentioning GDB 7?
Or do you have in mind some other specific idea of improving this comment?

We could direct the reader to Doc/howto/gdb_helpers.rst maybe?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@StanFromIreland

StanFromIreland commented Jan 18, 2026

Copy link
Copy Markdown
Member

Oh I only have the one line shown, I was referring to: "see Misc/gdbinit in the sources of Python 3.11 or earlier."

johnslavik reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@johnslavik

johnslavik commented Jan 18, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Thanks. Personally, I don't find it necessary, because the 3.11 and earlier branches still will include the mention of Misc/gdbinit after we merge this.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@StanFromIreland

StanFromIreland commented Jan 18, 2026

Copy link
Copy Markdown
Member

Why do those branches matter? The comment is for people on the branches where the file doesn't exist, no?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@johnslavik

johnslavik commented Jan 18, 2026

Copy link
Copy Markdown
Member Author

Why do those branches matter? The comment is for people on the branches where the file doesn't exist, no?

I was thinking that mentioning Misc/gdbinit would not be useful to people on branches that don't contain the file, because they wouldn't need nor be able to use the file.

If they needed to debug 3.11, they would check it out and the comment would be there.
Unless I am missing something?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@johnslavik

johnslavik commented Jan 18, 2026

Copy link
Copy Markdown
Member Author

Do you have an example of when this is useful for someone debugging in the 3.13-3.15 branches only?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ZeroIntensity

ZeroIntensity commented Jan 18, 2026

Copy link
Copy Markdown
Member

Yeah, I agree with Bartosz here. The mention in the docs was added after Misc/gdbinit was removed, so I think it's intentional to keep that one.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ZeroIntensity
ZeroIntensity approved these changes Jan 18, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jan 18, 2026
vstinner
vstinner approved these changes Jan 19, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

johnslavik reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@vstinner vstinner changed the title No longer mention Misc/gdbinit in the code gh-102809: No longer mention Misc/gdbinit in the code Jan 19, 2026
@vstinner vstinner removed the skip issue label Jan 19, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jan 19, 2026
What to do with Misc/gdbinit? #102809
Closed
@vstinner
vstinner merged commit f84ea11 into python:main Jan 19, 2026
61 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington-app

miss-islington-app Bot commented Jan 19, 2026

Copy link
Copy Markdown

Thanks @johnslavik for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 19, 2026
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 19, 2026
@johnslavik @miss-islington
pythongh-102809: No longer mention Misc/gdbinit in the code (python…
8340f58
…GH-143980)

Fix misleading comment on `PyObject_Dump`.
(cherry picked from commit f84ea11)

Co-authored-by: Bartosz Sławecki <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 19, 2026
@johnslavik @miss-islington
pythongh-102809: No longer mention Misc/gdbinit in the code (python…
34881e4
…GH-143980)

Fix misleading comment on `PyObject_Dump`.
(cherry picked from commit f84ea11)

Co-authored-by: Bartosz Sławecki <[email protected]>
@bedevere-app

bedevere-app Bot commented Jan 19, 2026

Copy link
Copy Markdown

GH-144044 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jan 19, 2026
@bedevere-app

bedevere-app Bot commented Jan 19, 2026

Copy link
Copy Markdown

GH-144045 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jan 19, 2026
@vstinner

vstinner commented Jan 19, 2026

Copy link
Copy Markdown
Member

Merged, thanks for this cleanup.

johnslavik reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@johnslavik

johnslavik commented Jan 19, 2026

Copy link
Copy Markdown
Member Author

@vstinner, thanks for the review and for linking the issue!

vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner pushed a commit that referenced this pull request Jan 19, 2026
@miss-islington @johnslavik
[3.13] gh-102809: No longer mention Misc/gdbinit in the code (GH-14…
7bca3dd
…3980) (#144045)

gh-102809: No longer mention `Misc/gdbinit` in the code (GH-143980)

Fix misleading comment on `PyObject_Dump`.
(cherry picked from commit f84ea11)

Co-authored-by: Bartosz Sławecki <[email protected]>
vstinner pushed a commit that referenced this pull request Jan 19, 2026
@miss-islington @johnslavik
[3.14] gh-102809: No longer mention Misc/gdbinit in the code (GH-14…
27256ca
…3980) (#144044)

gh-102809: No longer mention `Misc/gdbinit` in the code (GH-143980)

Fix misleading comment on `PyObject_Dump`.
(cherry picked from commit f84ea11)

Co-authored-by: Bartosz Sławecki <[email protected]>
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@johnslavik @thunder-coding
pythongh-102809: No longer mention Misc/gdbinit in the code (python…
746eb98
…#143980)

Fix misleading comment on `PyObject_Dump`.
@johnslavik
johnslavik deleted the farewell-gdbinit branch April 20, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments
@vstinner vstinner vstinner approved these changes
@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@johnslavik @StanFromIreland @ZeroIntensity @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.