GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||
GeezerVison is showing github.com — gh-102809: No longer mention `Misc/gdbinit` in the code by johnslavik · Pull Request #143980 · python/cpython Conversation
|
| - GDB 7 or later. (For earlier versions of GDB, see ``Misc/gdbinit`` in the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
I'm not sure. This comment remains on 3.10, 3.11 and 3.12 branches, would including We could direct the reader to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Oh I only have the one line shown, I was referring to: "see |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Thanks. Personally, I don't find it necessary, because the 3.11 and earlier branches still will include the mention of |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Why do those branches matter? The comment is for people on the branches where the file doesn't exist, no? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
I was thinking that mentioning If they needed to debug 3.11, they would check it out and the comment would be there. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Do you have an example of when this is useful for someone debugging in the 3.13-3.15 branches only? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Yeah, I agree with Bartosz here. The mention in the docs was added after |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Misc/gdbinit in the codeMisc/gdbinit in the code
There was an error while loading. Please reload this page.
|
Thanks @johnslavik for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…GH-143980) Fix misleading comment on `PyObject_Dump`. (cherry picked from commit f84ea11) Co-authored-by: Bartosz Sławecki <[email protected]>
…GH-143980) Fix misleading comment on `PyObject_Dump`. (cherry picked from commit f84ea11) Co-authored-by: Bartosz Sławecki <[email protected]>
|
GH-144044 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
GH-144045 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Merged, thanks for this cleanup. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@vstinner, thanks for the review and for linking the issue! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…#143980) Fix misleading comment on `PyObject_Dump`.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.