GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-144027: Fix documentation for ignorechars in base64.a85decode() by serhiy-storchaka · Pull Request #144028 · python/cpython

Conversation

serhiy-storchaka commented Jan 19, 2026 •

edited by github-actions Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

It does not support an ASCII string.

Also add more tests.

Issue: Incorrect documentation for ignorechars in base64.a85decode() #144027

📚 Documentation preview 📚: https://cpython-previews--144028.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-144027: Fix documentation for ignorechars in base64.a85decode()

a398754

It does not support an ASCII string.

Also add more tests.

bedevere-app Bot added the tests Tests in the Lib/test dir label

Jan 19, 2026

bedevere-app Bot mentioned this pull request

Jan 19, 2026

Incorrect documentation for ignorechars in base64.a85decode() #144027

Closed

bedevere-app Bot added the awaiting core review label

Jan 19, 2026

serhiy-storchaka requested a review from bitdancer

January 19, 2026 10:50

serhiy-storchaka added skip news needs backport to 3.13

only security fixes

needs backport to 3.14 bugs and security fixes labels

Jan 19, 2026

vstinner approved these changes

Jan 19, 2026

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting merge and removed awaiting core review labels

Jan 19, 2026

bitdancer requested changes

Jan 20, 2026

View reviewed changes

Comment thread

Doc/library/base64.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/test/test_base64.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot added awaiting changes and removed awaiting merge labels

Jan 20, 2026

bedevere-app Bot commented Jan 20, 2026

Copy link

Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bitdancer approved these changes

Jan 23, 2026

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting changes labels

Jan 23, 2026

serhiy-storchaka merged commit 25a10b6 into python:main

Jan 23, 2026

68 of 70 checks passed

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot commented Jan 23, 2026

Copy link

Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting merge label

Jan 23, 2026

serhiy-storchaka deleted the ascii85-decode-ignorechars branch

January 23, 2026 18:55

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jan 23, 2026


          pythongh-144027: Fix documentation for ignorechars in base64.a85decod…

172f12c

…e() (pythonGH-144028)

It does not support an ASCII string.

Also add more tests.
(cherry picked from commit 25a10b6)

Co-authored-by: Serhiy Storchaka <[email protected]>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jan 23, 2026


          pythongh-144027: Fix documentation for ignorechars in base64.a85decod…

3cb685e

…e() (pythonGH-144028)

It does not support an ASCII string.

Also add more tests.
(cherry picked from commit 25a10b6)

Co-authored-by: Serhiy Storchaka <[email protected]>

bedevere-app Bot commented Jan 23, 2026

Copy link

Copy Markdown

GH-144192 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label

Jan 23, 2026

bedevere-app Bot commented Jan 23, 2026

Copy link

Copy Markdown

GH-144193 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label

Jan 23, 2026

serhiy-storchaka added a commit that referenced this pull request

Jan 23, 2026


          [3.13] gh-144027: Fix documentation for ignorechars in base64.a85deco…

cbfebb1

…de() (GH-144028) (GH-144193)

It does not support an ASCII string.

Also add more tests.
(cherry picked from commit 25a10b6)

Co-authored-by: Serhiy Storchaka <[email protected]>

serhiy-storchaka added a commit that referenced this pull request

Jan 23, 2026


          [3.14] gh-144027: Fix documentation for ignorechars in base64.a85deco…

1947d6e

…de() (GH-144028) (GH-144192)

It does not support an ASCII string.

Also add more tests.
(cherry picked from commit 25a10b6)

Co-authored-by: Serhiy Storchaka <[email protected]>

thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request

Feb 15, 2026


          pythongh-144027: Fix documentation for ignorechars in base64.a85decod…

d6ceff4

…e() (pythonGH-144028)

It does not support an ASCII string.

Also add more tests.

Reviewers

vstinner

vstinner approved these changes

bitdancer

bitdancer approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

serhiy-storchaka commented Jan 19, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bedevere-app Bot commented Jan 20, 2026

Uh oh!

Uh oh!

miss-islington-app Bot commented Jan 23, 2026

Uh oh!

bedevere-app Bot commented Jan 23, 2026

Uh oh!

bedevere-app Bot commented Jan 23, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

serhiy-storchaka commented Jan 19, 2026 •

edited by github-actions Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.