GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-74902: Avoid hitting unicode.org for test data by zware · Pull Request #144195 · python/cpython

Conversation

@zware

@zware zware commented Jan 23, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Use our own pythontest.net instead.

  • Issue: Add unicode grapheme cluster break algorithm #74902

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zware
pythongh-74902: Avoid hitting unicode.org for test data
af1e9a7 
Use our own pythontest.net instead.
@zware zware added tests Tests in the Lib/test dir skip news topic-unicode labels Jan 23, 2026
@zware
zware requested a review from serhiy-storchaka January 23, 2026 19:48
@bedevere-app bedevere-app Bot mentioned this pull request Jan 23, 2026
Add unicode grapheme cluster break algorithm #74902
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 23, 2026
@zware

zware commented Jan 23, 2026

Copy link
Copy Markdown
Member Author

unicode.org returned 403s to a couple of my buildbot workers; using pythontest.net instead ensures that we're not taxing their server and puts the source of our test data in our control.

Test data added to pythontest.net in python/pythontestdotnet@a66b3bb
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka approved these changes Jan 23, 2026
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/test_unicodedata.py
f"into the test data directory")
except (OSError, HTTPException) as exc:
self.skipTest(f"Failed to download {TESTDATAURL}: {exc}")
TESTDATAFILE = "GraphemeBreakTest.txt"

@serhiy-storchaka serhiy-storchaka Jan 23, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, it is not in auxiliary?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@zware zware Jan 23, 2026

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not; since we only have three files in there (up from two before adding this one), the extra directory seemed unnecessary. Easy enough to add back if you want it, though.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jan 23, 2026
@zware
zware merged commit 58ccf21 into python:main Jan 23, 2026
57 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@zware
zware deleted the unicode_test_fixup branch January 23, 2026 21:07
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 23, 2026
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@zware @thunder-coding
pythongh-74902: Avoid hitting unicode.org for test data (pythonGH-144195
fc836b8 
)

Use our own pythontest.net instead.
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Apr 8, 2026
@zware @StanFromIreland
pythongh-74902: Avoid hitting unicode.org for test data (pythonGH-144195
9efe825 
)

Use our own pythontest.net instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-unicode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@zware @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.