GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-116738: Align bz2 unused_data getter to lzma implementation by yoney · Pull Request #144351 · python/cpython

Conversation

@yoney

@yoney yoney commented Jan 30, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This is a follow-up to #142947 to align bz2 with lzma implementations by returning b"" from unused_data getter when eof is not set (doc). It also refactors the unused_data to make it easier to read and to clearly show that self->unused_data cannot be NULL (since PyBytes_FromStringAndSize() only fails on allocation errors).

Ran the test with tsan build.

cc: @emmatyping @colesbury

  • Issue: Audit all built-in modules for thread safety #116738

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@yoney
Align bz2 unused_data getter to lzma
43dc39b
@bedevere-app bedevere-app Bot mentioned this pull request Jan 30, 2026
Audit all built-in modules for thread safety #116738
Open
@bedevere-app bedevere-app Bot added the awaiting review label Jan 30, 2026
gpshead
gpshead approved these changes Apr 11, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Apr 11, 2026
@gpshead gpshead added the skip news label Apr 11, 2026
@gpshead gpshead self-assigned this Apr 11, 2026
@gpshead

gpshead commented Apr 11, 2026

Copy link
Copy Markdown
Member

thanks! (skipping a news entry as this doesn't change anything meaningfully observable, only a generally implausible to code for case with a MemoryError buried in the midst to the circumstances)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead
gpshead merged commit afbe137 into python:main Apr 11, 2026
53 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 11, 2026
@gpshead gpshead added the needs backport to 3.14 bugs and security fixes label Apr 11, 2026
@miss-islington-app

miss-islington-app Bot commented Apr 11, 2026

Copy link
Copy Markdown

Thanks @yoney for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Apr 11, 2026

Copy link
Copy Markdown

Sorry, @yoney and @gpshead, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker afbe1373ac9ac96149936211b2df71c2b6f97a4b 3.14
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead gpshead removed the needs backport to 3.14 bugs and security fixes label Apr 11, 2026
@gpshead

gpshead commented Apr 11, 2026

Copy link
Copy Markdown
Member

not worrying about the backport, that was just to see if it was easy.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@yoney @ljfp
pythongh-116738: Align bz2 unused_data getter to lzma implementation (p…
f55ed21 
…ythonGH-144351)

Align bz2 unused_data getter to lzma
@yoney
yoney deleted the ft_bz2 branch September 11, 2026 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@yoney @gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.