GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-139109: Replace `_CHECK_STACK_SPACE` with `_CHECK_STACK_SPACE_OPERAND` in JIT optiimizer by cocolato · Pull Request #144394 · python/cpython

Conversation

@cocolato

@cocolato cocolato commented Feb 2, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Refer: #144388
This implements a simple one-to-one replacement of _CHECK_STACK_SPACE with _CHECK_STACK_SPACE_OPERAND in the JIT optimizer.
Also open and rewrite all the tests that are disabled in #139109.

  • Issue: Trace recording JIT #139109

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cocolato
Replace _CHECK_STACK_SPACE with _CHECK_STACK_SPACE_OPERAND in JIT opt…
f05c6af 
…imizer
@cocolato
cocolato requested review from Fidget-Spinner, markshannon, savannahostrowski and tomasr8 as code owners February 2, 2026 14:22
@bedevere-app bedevere-app Bot added the awaiting review label Feb 2, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Feb 2, 2026
Trace recording JIT #139109
Open
cocolato
cocolato commented Feb 2, 2026
View reviewed changes
Comment thread Lib/test/test_capi/test_opt.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
markshannon
markshannon requested changes Feb 2, 2026
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good generally.
I suspect that using ADD_OP and REPLACE_OP together may be broken, but that won't matter if we make _CHECK_STACK_SPACE_OPERAND only check stack space.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cocolato reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread Lib/test/test_capi/test_opt.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/optimizer_bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/optimizer_bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Feb 2, 2026
@bedevere-app

bedevere-app Bot commented Feb 2, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the awaiting changes label Feb 2, 2026
@cocolato
refact _CHECK_STACK_SPACE && fix tests
c33f2ab
@markshannon markshannon added the skip news label Feb 2, 2026
@cocolato
fix tests
3ed9164
@cocolato

cocolato commented Feb 2, 2026

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting change review and removed awaiting changes labels Feb 2, 2026
@bedevere-app

bedevere-app Bot commented Feb 2, 2026

Copy link
Copy Markdown

Thanks for making the requested changes!

@markshannon: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app
bedevere-app Bot requested a review from markshannon February 2, 2026 16:23
markshannon
markshannon approved these changes Feb 2, 2026
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now, thanks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting change review labels Feb 2, 2026
@markshannon
markshannon merged commit 89e6607 into python:main Feb 2, 2026
74 of 77 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 2, 2026
Aniketsy pushed a commit to Aniketsy/cpython that referenced this pull request Feb 3, 2026
@cocolato @Aniketsy
pythongh-139109: Replace _CHECK_STACK_SPACE with `_CHECK_STACK_SPAC…
9c07998 
…E_OPERAND` in JIT optiimizer (pythonGH-144394)
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@cocolato @thunder-coding
pythongh-139109: Replace _CHECK_STACK_SPACE with `_CHECK_STACK_SPAC…
9d90bcc 
…E_OPERAND` in JIT optiimizer (pythonGH-144394)
@cocolato
cocolato deleted the optimize/CHECK_STACK_SPACE branch March 17, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes
@tomasr8 tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner
@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@cocolato @markshannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.