GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-142349: Fix build errors from PEP 810 by pablogsal · Pull Request #144726 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Feb 12, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The PEP 810 commit added an is_lazy parameter to _PyAST_ImportFrom but did not update the test_peg_generator test that calls this function directly from a custom grammar. It also introduced a trailing comma in the PyImport_LazyImportsMode enum which is invalid under C++03 with -pedantic-errors, breaking test_cppext.

Pass 0 for the new is_lazy argument in the test grammar's _PyAST_ImportFrom calls, and remove the trailing comma from the enum definition to restore C++03 compatibility.

  • Issue: Implement PEP 810 – Explicit lazy imports #142349

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@pablogsal
pythongh-142349: Fix build errors from PEP 810
60dafbb
The PEP 810 commit added an is_lazy parameter to _PyAST_ImportFrom
but did not update the test_peg_generator test that calls this
function directly from a custom grammar. It also introduced a
trailing comma in the PyImport_LazyImportsMode enum which is
invalid under C++03 with -pedantic-errors, breaking test_cppext.

Pass 0 for the new is_lazy argument in the test grammar's
_PyAST_ImportFrom calls, and remove the trailing comma from the
enum definition to restore C++03 compatibility.
@pablogsal pablogsal added the skip news label Feb 12, 2026
@pablogsal
pablogsal requested review from brettcannon, ericsnowcurrently, lysnikolaou, ncoghlan and warsaw as code owners February 12, 2026 00:34
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 12, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Feb 12, 2026
Implement PEP 810 – Explicit lazy imports #142349
Closed
@pablogsal pablogsal mentioned this pull request Feb 12, 2026
gh-142349: Implement PEP 810 - Explicit lazy imports #142351
Merged
@pablogsal
pablogsal requested review from DinoV and Yhg1s February 12, 2026 00:35
@pablogsal
pablogsal enabled auto-merge (squash) February 12, 2026 00:35
Fidget-Spinner
Fidget-Spinner approved these changes Feb 12, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 12, 2026
@danielhollas

danielhollas commented Feb 12, 2026

Copy link
Copy Markdown
Contributor

(looks like the TSAN tests are stuck?)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal
pablogsal merged commit 7854597 into python:main Feb 12, 2026
89 of 91 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal
pablogsal deleted the lazy-cleanup branch February 12, 2026 08:18
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 12, 2026
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@pablogsal @thunder-coding
pythongh-142349: Fix build errors from PEP 810 (python#144726)
13e4bb0
brijkapadia pushed a commit to brijkapadia/cpython that referenced this pull request Feb 28, 2026
@pablogsal @brijkapadia
pythongh-142349: Fix build errors from PEP 810 (python#144726)
dae3dda
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@pablogsal @ljfp
pythongh-142349: Fix build errors from PEP 810 (python#144726)
4181b26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@DinoV DinoV Awaiting requested review from DinoV
@Yhg1s Yhg1s Awaiting requested review from Yhg1s

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@pablogsal @danielhollas @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.