GeezerVison is showing github.com — gh-142349: Fix build errors from PEP 810 by pablogsal · Pull Request #144726 · python/cpython
Conversation
pablogsal
commented
Feb 12, 2026
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
The PEP 810 commit added an is_lazy parameter to _PyAST_ImportFrom but did not update the test_peg_generator test that calls this function directly from a custom grammar. It also introduced a trailing comma in the PyImport_LazyImportsMode enum which is invalid under C++03 with -pedantic-errors, breaking test_cppext.
Pass 0 for the new is_lazy argument in the test grammar's _PyAST_ImportFrom calls, and remove the trailing comma from the enum definition to restore C++03 compatibility.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
The PEP 810 commit added an is_lazy parameter to _PyAST_ImportFrom
but did not update the test_peg_generator test that calls this
function directly from a custom grammar. It also introduced a
trailing comma in the PyImport_LazyImportsMode enum which is
invalid under C++03 with -pedantic-errors, breaking test_cppext.
Pass 0 for the new is_lazy argument in the test grammar's
_PyAST_ImportFrom calls, and remove the trailing comma from the
enum definition to restore C++03 compatibility.
|
(looks like the TSAN tests are stuck?)
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.