GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-144601: Use `_testmultiphase` instead of `_testsinglephase` in `test_importlib` by ZeroIntensity · Pull Request #144769 · python/cpython

Conversation

@ZeroIntensity

@ZeroIntensity ZeroIntensity commented Feb 12, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

test_importlib.util is useful for subinterpreter tests, but they can't use it due to the import of _testsinglephase (which, you guessed it, is a single-phase extension). This problem is currently blocking the backport of GH-144602 (GH-144633).

On the main branch, this change was already made as part of GH-141785. As far as I can tell, nothing else from that PR needs to be backported to make this change.

  • Issue: Extensions that raise exceptions in their PyInit* cause a crash in subinterpreters #144601

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ZeroIntensity
Use _testmultiphase instead of _testsinglephase.
8a3b5da
@ZeroIntensity
ZeroIntensity requested a review from encukou February 12, 2026 23:28
@ZeroIntensity
ZeroIntensity requested review from brettcannon, ericsnowcurrently, ncoghlan and warsaw as code owners February 12, 2026 23:28
@ZeroIntensity ZeroIntensity added tests Tests in the Lib/test dir skip news needs backport to 3.13 only security fixes labels Feb 12, 2026
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 12, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Feb 12, 2026
Extensions that raise exceptions in their PyInit* cause a crash in subinterpreters #144601
Closed
@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 13, 2026
@bedevere-bot

bedevere-bot commented Feb 13, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 8a3b5da 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F144769%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 13, 2026
@encukou
encukou merged commit d148662 into python:3.14 Feb 16, 2026
126 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Feb 16, 2026
@miss-islington-app

miss-islington-app Bot commented Feb 16, 2026

Copy link
Copy Markdown

Thanks @ZeroIntensity for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 16, 2026
@ZeroIntensity @miss-islington
[3.14] pythongh-144601: Use _testmultiphase instead of `_testsingle…
a48159f 
…phase` in `test_importlib` (pythonGH-144769)

(cherry picked from commit d148662)

Co-authored-by: Peter Bierma <[email protected]>
@bedevere-app

bedevere-app Bot commented Feb 16, 2026

Copy link
Copy Markdown

GH-144877 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Feb 16, 2026
ZeroIntensity added a commit that referenced this pull request Feb 16, 2026
@miss-islington @ZeroIntensity
[3.13] gh-144601: Use _testmultiphase instead of _testsinglephase…
e701a5c 
… in `test_importlib` (GH-144769) (GH-144877)

[3.14] gh-144601: Use `_testmultiphase` instead of `_testsinglephase` in `test_importlib` (GH-144769)
(cherry picked from commit d148662)

Co-authored-by: Peter Bierma <[email protected]>
@ZeroIntensity
ZeroIntensity deleted the allow-subinterp-importlib-utils branch February 16, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou Awaiting requested review from encukou
@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ZeroIntensity @bedevere-bot @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.