GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-142224: `makeunicodedata.py`: parse default bidi values by StanFromIreland · Pull Request #144815 · python/cpython

Conversation

StanFromIreland commented Feb 14, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Issue: unicodedata.bidirectional does not return expected default value for certain code points #142224

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka reacted with thumbs up emoji

All reactions

👍 1 reaction


          Parse bidi defaults for unassigned code points

acb61d0

StanFromIreland requested a review from serhiy-storchaka

February 14, 2026 11:15

bedevere-app Bot added the awaiting review label

Feb 14, 2026

bedevere-app Bot mentioned this pull request

Feb 14, 2026

unicodedata.bidirectional does not return expected default value for certain code points #142224

Closed

StanFromIreland requested review from benjaminp and malemburg

February 14, 2026 16:10

serhiy-storchaka reviewed

Feb 17, 2026

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to work on this issue next week, but you saved my time. Thank you.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Tools/unicode/makeunicodedata.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Tools/unicode/makeunicodedata.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Tools/unicode/makeunicodedata.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

StanFromIreland added 2 commits

February 17, 2026 18:10


          Updates for Serhiy

b665e66


          Merge branch 'main' into unicodetata-bidis

# Conflicts:
#	Lib/test/test_unicodedata.py
#	Tools/unicode/makeunicodedata.py

StanFromIreland requested a review from serhiy-storchaka

February 17, 2026 18:21


          Update checksum

a51525d

serhiy-storchaka reviewed

Feb 18, 2026

View reviewed changes

Comment thread

Tools/unicode/makeunicodedata.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Tools/unicode/makeunicodedata.py Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Review

6a664e5

malemburg commented Feb 18, 2026

Copy link

Copy Markdown

Member

Sorry, I don't have time for a true review. From a casual look, this LGTM, though.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka approved these changes

Feb 18, 2026

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting merge and removed awaiting review labels

Feb 18, 2026

serhiy-storchaka merged commit e49bfca into python:main

Feb 18, 2026

51 checks passed

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting merge label

Feb 18, 2026

serhiy-storchaka added needs backport to 3.13

only security fixes

needs backport to 3.14 bugs and security fixes labels

Feb 18, 2026

miss-islington-app Bot commented Feb 18, 2026

Copy link

Copy Markdown

Thanks @StanFromIreland for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot commented Feb 18, 2026

Copy link

Copy Markdown

Thanks @StanFromIreland for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot commented Feb 18, 2026

Copy link

Copy Markdown

Sorry, @StanFromIreland and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e49bfca87cc188c271946491edc33831a901c7f1 3.13

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot assigned serhiy-storchaka

Feb 18, 2026

miss-islington-app Bot commented Feb 18, 2026

Copy link

Copy Markdown

Sorry, @StanFromIreland and @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e49bfca87cc188c271946491edc33831a901c7f1 3.14

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka removed needs backport to 3.13

only security fixes

needs backport to 3.14 bugs and security fixes labels

Feb 18, 2026

serhiy-storchaka commented Feb 18, 2026

Copy link

Copy Markdown

Member

I am not sure if it is worth to backport this.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

StanFromIreland deleted the unicodetata-bidis branch

February 18, 2026 10:59

StanFromIreland commented Feb 18, 2026

Copy link

Copy Markdown

Member Author

Sorry, I don't have time for a true review. From a casual look, this LGTM, though.

No worries, thanks for the reviews.

I am not sure if it is worth to backport this.

Yes, I would think it is an uncommon issue.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

brijkapadia pushed a commit to brijkapadia/cpython that referenced this pull request

Feb 28, 2026


          pythongh-142224: unicodedata: support bidi classes for unassigned cod…

80e9d32

…e points (pythonGH-144815)

ljfp pushed a commit to ljfp/cpython that referenced this pull request

Apr 25, 2026


          pythongh-142224: unicodedata: support bidi classes for unassigned cod…

26586b9

…e points (pythonGH-144815)

serhiy-storchaka removed their assignment

Jul 15, 2026

encukou added a commit to encukou/cpython that referenced this pull request

Aug 18, 2026


          Re-add test from pythonGH-144815

ff4f6df

encukou mentioned this pull request

Aug 18, 2026

[3.14] gh-155292: Don't consider Unicode codepoint attributes outside RFC 3454 (GH-155293) #156020

Merged

encukou added a commit that referenced this pull request

Sep 4, 2026


          [3.14] gh-155292: Don't consider Unicode codepoint attributes outside…

1e54caa

… RFC 3454 (GH-155293) (GH-156020)

Due to a bug, some Unicode codepoint attributes were considered
for characters not yet defined in Unicode 3.2.0 or attributes
which changed in later Unicode versions. RFC 3454 (StringPrep)
requires using Unicode 3.2.0 strictly.

(cherry picked from commit 7e109d0)
The cherry-pick needed reworking as GH-144815 wasn't backported to 3.14
and below, so unassigned characters don't have bidi values.

Co-authored-by: Seth Larson <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>

miss-islington mentioned this pull request

Sep 4, 2026

[3.13] gh-155292: Don't consider Unicode codepoint attributes outside RFC 3454 (GH-155293) (GH-156020) #156922

Merged

This was referenced Sep 4, 2026

[3.12] gh-155292: Don't consider Unicode codepoint attributes outside RFC 3454 (GH-155293) (GH-156020) #156930

Merged

[3.11] gh-155292: Don't consider Unicode codepoint attributes outside RFC 3454 (GH-155293) (GH-156020) #156931

Merged

[3.10] gh-155292: Don't consider Unicode codepoint attributes outside RFC 3454 (GH-155293) (GH-156020) #156932

Merged

Yhg1s pushed a commit that referenced this pull request

Sep 8, 2026


          [3.12] gh-155292: Don't consider Unicode codepoint attributes outside…

c016c25

… RFC 3454 (GH-155293) (GH-156020) (#156930)

Due to a bug, some Unicode codepoint attributes were considered
for characters not yet defined in Unicode 3.2.0 or attributes
which changed in later Unicode versions. RFC 3454 (StringPrep)
requires using Unicode 3.2.0 strictly.

(cherry picked from commit 7e109d0)
The cherry-pick needed reworking as GH-144815 wasn't backported to 3.14
and below, so unassigned characters don't have bidi values.
(cherry picked from commit 1e54caa)
Also, add Unicode_3_2_0_FunctionsTest as in the later versions,
to make the new test work.

Co-authored-by: Seth Larson [email protected]
Co-authored-by: Stan Ulbrych [email protected]
Co-authored-by: Petr Viktorin [email protected]

encukou added a commit that referenced this pull request

Sep 9, 2026


          [3.13] gh-155292: Don't consider Unicode codepoint attributes outside…

c28b121

… RFC 3454 (GH-155293) (GH-156020) (GH-156922)

Due to a bug, some Unicode codepoint attributes were considered
for characters not yet defined in Unicode 3.2.0 or attributes
which changed in later Unicode versions. RFC 3454 (StringPrep)
requires using Unicode 3.2.0 strictly.

(cherry picked from commit 7e109d0)
The cherry-pick needed reworking as GH-144815 wasn't backported to 3.14
and below, so unassigned characters don't have bidi values.
(cherry picked from commit 1e54caa)

Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: Seth Larson <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>

---------

Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: Seth Larson <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>

pablogsal pushed a commit that referenced this pull request

Oct 1, 2026


          [3.10] gh-155292: Don't consider Unicode codepoint attributes outside…

d397a49

… RFC 3454 (GH-155293) (GH-156020) (#156932)

* [3.10] gh-155292: Don't consider Unicode codepoint attributes outside RFC 3454 (GH-155293) (GH-156020)

Due to a bug, some Unicode codepoint attributes were considered
for characters not yet defined in Unicode 3.2.0 or attributes
which changed in later Unicode versions. RFC 3454 (StringPrep)
requires using Unicode 3.2.0 strictly.

(cherry picked from commit 7e109d0)
The cherry-pick needed reworking as GH-144815 wasn't backported to 3.14
and below, so unassigned characters don't have bidi values.
(cherry picked from commit 1e54caa)

Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: Seth Larson <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>

* Add Unicode_3_2_0_FunctionsTest

* Regenerate Unicode data

---------

Co-authored-by: Seth Larson <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>

pablogsal pushed a commit that referenced this pull request

Oct 1, 2026


          [3.11] gh-155292: Don't consider Unicode codepoint attributes outside…

69f92eb

… RFC 3454 (GH-155293) (GH-156020) (#156931)

* [3.11] gh-155292: Don't consider Unicode codepoint attributes outside RFC 3454 (GH-155293) (GH-156020)

Due to a bug, some Unicode codepoint attributes were considered
for characters not yet defined in Unicode 3.2.0 or attributes
which changed in later Unicode versions. RFC 3454 (StringPrep)
requires using Unicode 3.2.0 strictly.

(cherry picked from commit 7e109d0)
The cherry-pick needed reworking as GH-144815 wasn't backported to 3.14
and below, so unassigned characters don't have bidi values.

Co-authored-by: Seth Larson <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>
(cherry picked from commit 1e54caa)

* Add Unicode_3_2_0_FunctionsTest

* Regenerate Unicode data

---------

Co-authored-by: Seth Larson <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>

icanhasmath pushed a commit to ActiveState/cpython that referenced this pull request

Oct 28, 2026


          [3.10] pythongh-155292: Don't consider Unicode codepoint attributes o…

eb1b45f

…utside RFC 3454 (pythonGH-155293) (pythonGH-156020) (python#156932)

* [3.10] pythongh-155292: Don't consider Unicode codepoint attributes outside RFC 3454 (pythonGH-155293) (pythonGH-156020)

Due to a bug, some Unicode codepoint attributes were considered
for characters not yet defined in Unicode 3.2.0 or attributes
which changed in later Unicode versions. RFC 3454 (StringPrep)
requires using Unicode 3.2.0 strictly.

(cherry picked from commit 7e109d0)
The cherry-pick needed reworking as pythonGH-144815 wasn't backported to 3.14
and below, so unassigned characters don't have bidi values.
(cherry picked from commit 1e54caa)

Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: Seth Larson <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>

* Add Unicode_3_2_0_FunctionsTest

* Regenerate Unicode data

---------

Co-authored-by: Seth Larson <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
(cherry picked from commit d397a49)

Reviewers

serhiy-storchaka

serhiy-storchaka approved these changes

benjaminp

Awaiting requested review from benjaminp

malemburg

Awaiting requested review from malemburg

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

StanFromIreland commented Feb 14, 2026 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

malemburg commented Feb 18, 2026

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-app Bot commented Feb 18, 2026

Uh oh!

miss-islington-app Bot commented Feb 18, 2026

Uh oh!

miss-islington-app Bot commented Feb 18, 2026

Uh oh!

miss-islington-app Bot commented Feb 18, 2026

Uh oh!

serhiy-storchaka commented Feb 18, 2026

Uh oh!

StanFromIreland commented Feb 18, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

StanFromIreland commented Feb 14, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.