GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-142349: Clarify lazy import filters have positional-only parameters by johnslavik · Pull Request #144856 · python/cpython

Conversation

@johnslavik

@johnslavik johnslavik commented Feb 15, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Failing example:

import sys

sys.set_lazy_imports_filter(lambda *, importing_module, imported_module, fromlist: True)

lazy import foobar
  • Issue: Implement PEP 810 – Explicit lazy imports #142349

📚 Documentation preview 📚: https://cpython-previews--144856.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@johnslavik
Clarify lazy import filters have positional-only arguments
f869e9c
@johnslavik johnslavik added the skip news label Feb 15, 2026
@bedevere-app bedevere-app Bot added the awaiting review label Feb 15, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Feb 15, 2026
Update function signatures to use * and / as needed #131885
Open
4 of 5 tasks
@bedevere-app bedevere-app Bot added the docs Documentation in the Doc dir label Feb 15, 2026
@github-project-automation github-project-automation Bot added this to Docs PRs Feb 15, 2026
@johnslavik johnslavik changed the title gh-131885: Clarify lazy import filters have positional-only arguments gh-131885: Clarify lazy import filters have positional-only parameters Feb 15, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Feb 15, 2026
@johnslavik
johnslavik requested a review from AA-Turner February 15, 2026 23:56
AA-Turner
AA-Turner previously requested changes Feb 15, 2026
View reviewed changes
Comment thread Doc/library/sys.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting changes and removed awaiting review labels Feb 15, 2026
@bedevere-app

bedevere-app Bot commented Feb 15, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@johnslavik
Don't describe arguments as positional in written sentences
4eebd62
@johnslavik

johnslavik commented Feb 16, 2026

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting change review and removed awaiting changes labels Feb 16, 2026
@bedevere-app

bedevere-app Bot commented Feb 16, 2026

Copy link
Copy Markdown

Thanks for making the requested changes!

@AA-Turner: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app
bedevere-app Bot requested a review from AA-Turner February 16, 2026 00:07
@johnslavik

johnslavik commented Feb 21, 2026

Copy link
Copy Markdown
Member Author

@AA-Turner :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Yhg1s Yhg1s added the topic-lazy-imports label Mar 17, 2026
@johnslavik

johnslavik commented Mar 20, 2026

Copy link
Copy Markdown
Member Author

@AA-Turner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@johnslavik

johnslavik commented Apr 15, 2026

Copy link
Copy Markdown
Member Author

@AA-Turner (If you can't look into this I'll appreciate if you just tell! Thanks!)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented May 17, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label May 17, 2026
@johnslavik

johnslavik commented May 17, 2026

Copy link
Copy Markdown
Member Author

@AA-Turner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label May 26, 2026
@johnslavik

johnslavik commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

@AA-Turner :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
johnslavik added 2 commits July 24, 2026 20:57
@johnslavik
Make the docs more correct
d4c5563
@johnslavik
Remove the trailing /
ca4de39
@johnslavik
johnslavik requested a review from encukou July 24, 2026 18:59
@johnslavik

johnslavik commented Jul 24, 2026

Copy link
Copy Markdown
Member Author

I'm requesting a review from @encukou as Adam is unavailable.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@read-the-docs-community

read-the-docs-community Bot commented Jul 24, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33779896 | 📁 Comparing 9a2a9f4 against main (46acb79)

  🔍 Preview build  

7 files changed · ± 7 modified

± Modified

  • license.html
  • library/asyncio-eventloop.html
  • library/ctypes.html
  • library/difflib.html
  • library/sys.html
  • whatsnew/3.15.html
  • whatsnew/changelog.html
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
encukou
encukou reviewed Jul 24, 2026
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asking for review is asking for nitpicks, right?

Please click "update branch" or do git merge main (depending on your workflow) to get the tools the current CI needs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/sys.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/sys.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
johnslavik and others added 2 commits July 25, 2026 09:45
@johnslavik @encukou
Apply suggestions from code review
ec8e313 
Co-authored-by: Petr Viktorin <[email protected]>
@johnslavik
Merge branch 'main' into lazy-imports-filter-clarify-signature-positi…
d2d90b4 
…onal
@johnslavik
johnslavik requested a review from encukou July 25, 2026 07:57
@johnslavik

johnslavik commented Jul 25, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Thank you so much for providing the suggestions!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@johnslavik johnslavik changed the title gh-131885: Clarify lazy import filters have positional-only parameters gh-142349: Clarify lazy import filters have positional-only parameters Jul 25, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jul 25, 2026
Implement PEP 810 – Explicit lazy imports #142349
Closed
@johnslavik

johnslavik commented Jul 25, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Changed the targeted issue to match.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
encukou
encukou reviewed Jul 27, 2026
View reviewed changes
Comment thread Doc/library/sys.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@encukou
Remove redundant paragraph
9a2a9f4
@encukou encukou added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes and removed needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Jul 27, 2026
@encukou
encukou dismissed AA-Turner’s stale review July 27, 2026 14:49

Requested changes were made.

@bedevere-app bedevere-app Bot added awaiting review and removed awaiting change review labels Jul 27, 2026
@encukou
encukou merged commit 66eb823 into python:main Jul 28, 2026
58 of 65 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Jul 28, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Jul 28, 2026
@miss-islington-app

miss-islington-app Bot commented Jul 28, 2026

Copy link
Copy Markdown

Thanks @johnslavik for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Jul 28, 2026

Copy link
Copy Markdown

GH-154808 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Jul 28, 2026
encukou pushed a commit that referenced this pull request Jul 28, 2026
@miss-islington @johnslavik
[3.15] gh-142349: Clarify lazy import filters have positional-only pa…
3e670c3 
…rameters (GH-144856) (GH-154808)

(cherry picked from commit 66eb823)

Co-authored-by: Bartosz Sławecki <[email protected]>
mbeijen pushed a commit to mbeijen/cpython that referenced this pull request Aug 14, 2026
@johnslavik @mbeijen
pythongh-142349: Clarify lazy import filters have positional-only par…
c902502 
…ameters (pythonGH-144856)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments
@AA-Turner AA-Turner Awaiting requested review from AA-Turner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news topic-lazy-imports

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@johnslavik @encukou @AA-Turner @Yhg1s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.