GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-142927: Detect system theme in flame graph like in heatmap by hugovk · Pull Request #144885 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Feb 16, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The heatmap initially detects the user's preferred theme (via prefers-color-scheme) but the flame graph does not.

This PR allows the flame graph to do the same, and refactors some shared JavaScript code into a new base.js file to avoid duplication.

  • Issue: Improve Tachyon UX #142927

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
hugovk added 2 commits February 16, 2026 19:27
@hugovk
Detect system theme in flame graph
78bbbcc
@hugovk
Move duplicate updateToggleUI function to base.js
ee235d3
@hugovk
hugovk requested a review from pablogsal as a code owner February 16, 2026 17:38
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 16, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Feb 16, 2026
Improve Tachyon UX #142927
Open
11 tasks done
@hugovk hugovk added the skip news label Feb 16, 2026
pablogsal
pablogsal approved these changes Feb 16, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 16, 2026
@pablogsal

pablogsal commented Feb 16, 2026

Copy link
Copy Markdown
Member

Thanks @hugovk ❤️
hugovk reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk merged commit 368a267 into python:main Mar 10, 2026
53 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk deleted the 3.15-tachyon-heatmap-detect-theme branch March 10, 2026 11:38
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 10, 2026
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@hugovk @ljfp
pythongh-142927: Detect system theme in flame graph like in heatmap (p…
5565280 
…ython#144885)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hugovk @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.