GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||
GeezerVison is showing github.com — gh-141510: Replace MappingProxyType with frozendict by vstinner · Pull Request #144904 · python/cpython Conversation
|
|
Oh, the "Run mypy on Lib/tomllib" job fails with "Name frozendict is not defined" because it runs on an older Python version which doesn't have this new built-in type: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I reverted the tomllib change to workaround the mypy issue. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Approving the email change only, I'm not familiar with the other code bases.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
cc @picnixz |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Ok for HMAC & other hashlib-related changes (they are only tests and essentially, I wanted an immutable view of a mapping so it serves us well)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Oh, tests are failing 0:13:17 load avg: 10.90 [1/1/1] test_dataclasses failed (1 failure) FAIL: test_field_repr (test.test_dataclasses.TestCase.test_field_repr)Traceback (most recent call last): |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I'll have a look on this as soon as I've got some time |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I updated my branch and I updated test_dataclasses for
I updated |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
LGTM |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Merged. Thanks for reviews. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.