GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-134584 : Optimize and eliminate redundant ref-counting for `MAKE_FUNCTION` in the JIT by Sacul0457 · Pull Request #144963 · python/cpython

Conversation

@Sacul0457

@Sacul0457 Sacul0457 commented Feb 18, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Thanks to @Fidget-Spinner for guiding!

Adds _MAKE_FUNCTION to optimizer_bytecodes.c and eliminates redundant ref-counting for MAKE_FUNCTION.

  • Issue: Eliminate redundant refcounting in the JIT #134584

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Sacul0457
Optimize MAKE_FUNCTION
969939d
@Sacul0457
Sacul0457 requested review from Fidget-Spinner, markshannon, savannahostrowski and tomasr8 as code owners February 18, 2026 16:53
@bedevere-app bedevere-app Bot added the awaiting review label Feb 18, 2026
@blurb-it
📜🤖 Added by blurb_it.
9fee2fe
@Fidget-Spinner

Fidget-Spinner commented Feb 18, 2026

Copy link
Copy Markdown
Member

MAKE_FUNCTION might not be a common opcode/show up in the JIT. So I doubt we will see speedups from this one, it's still good to add it to the optimizer though so thanks.
Sacul0457 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot mentioned this pull request Feb 18, 2026
Eliminate redundant refcounting in the JIT #134584
Closed
35 tasks done
markshannon
markshannon approved these changes Mar 12, 2026
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
@Sacul0457 can you update this branch so it can be merged?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sacul0457 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Mar 12, 2026
Sacul0457 added 2 commits March 13, 2026 15:00
@Sacul0457
Merge branch 'main' into Optimize_MAKE_FUNCTION
9b3430c
@Sacul0457
regen files
4fe5ed2
@Sacul0457

Sacul0457 commented Mar 13, 2026

Copy link
Copy Markdown
Contributor Author

I'm can't seem to find the error logs for the CI failure, so I'm not sure what's the cause of the failure and whether it's related to this PR or not
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner

Fidget-Spinner commented Mar 13, 2026

Copy link
Copy Markdown
Member

Sometimes the sanitizer CI is a little flaky, so I've triggered a re-run.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Sacul0457

Sacul0457 commented Mar 13, 2026

Copy link
Copy Markdown
Contributor Author

Seems to pass now, thx!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sacul0457 added 2 commits March 15, 2026 22:40
@Sacul0457
Merge branch 'main' into Optimize_MAKE_FUNCTION
b218bae
@Sacul0457
transfer ownership only after error branch case
e80c556
@kumaraditya303

kumaraditya303 commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

There are new merge conflicts.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sacul0457 added 2 commits March 19, 2026 20:07
@Sacul0457
Merge branch 'main' into Optimize_MAKE_FUNCTION
3662b70
@Sacul0457
regen files
f1a2fce
@Sacul0457

Sacul0457 commented Mar 19, 2026

Copy link
Copy Markdown
Contributor Author

fixed :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sacul0457 added 4 commits March 29, 2026 01:18
@Sacul0457
Merge branch 'main' into Optimize_MAKE_FUNCTION
03670af
@Sacul0457
regen files
9d937a3
@Sacul0457
Merge branch 'main' into Optimize_MAKE_FUNCTION
8865d5b
@Sacul0457
regen files
d67f420
@savannahostrowski

savannahostrowski commented Apr 9, 2026

Copy link
Copy Markdown
Member

Looks like this needs another regen, mind resolving @Sacul0457?
Sacul0457 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sacul0457 added 2 commits April 9, 2026 12:58
@Sacul0457
Merge branch 'main' into Optimize_MAKE_FUNCTION
4df290d
@Sacul0457
regen files
603f0bd
@Sacul0457

Sacul0457 commented Apr 9, 2026

Copy link
Copy Markdown
Contributor Author

Fixed!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner

Fidget-Spinner commented Apr 9, 2026

Copy link
Copy Markdown
Member

Sorry this needs merging main again. JIT development has been very active these days 🌀
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sacul0457 added 2 commits April 9, 2026 20:52
@Sacul0457
Merge branch 'main' into Optimize_MAKE_FUNCTION
9030ef9
@Sacul0457
regen files
75127aa
@Sacul0457

Sacul0457 commented Apr 9, 2026

Copy link
Copy Markdown
Contributor Author

No worries, it's great to hear how active the JIT development is :)
savannahostrowski reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner Fidget-Spinner mentioned this pull request Apr 9, 2026
gh-148211: decompose _INSERT_1_LOAD_CONST_INLINE(_BORROW) in JIT #148283
Merged
@Fidget-Spinner
Fidget-Spinner merged commit 38d3aef into python:main Apr 9, 2026
77 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 9, 2026
@Sacul0457
Sacul0457 deleted the Optimize_MAKE_FUNCTION branch April 10, 2026 16:20
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@Sacul0457 @ljfp
pythongh-134584 : Optimize and eliminate redundant ref-counting for `…
b6dbcbb 
…MAKE_FUNCTION` in the JIT (pythonGH-144963)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes
@tomasr8 tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner
@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Sacul0457 @Fidget-Spinner @kumaraditya303 @savannahostrowski @markshannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.