GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-145035: Allows removing the _pyrepl module to completely disable the modern REPL by zooba · Pull Request #145159 · python/cpython

Conversation

@zooba

@zooba zooba commented Feb 23, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is an unsupported configuration, but still desirable for some distributions. It also ensures we can continue to keep ctypes as an optional module.

  • Issue: Allow omitting _pyrepl module #145035

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@zooba
pythongh-145035: Allows removing the _pyrepl module to completely dis…
0f565c2
…able the modern REPL.
@bedevere-app bedevere-app Bot mentioned this pull request Feb 23, 2026
Allow omitting _pyrepl module #145035
Closed
@zooba

zooba commented Feb 23, 2026

Copy link
Copy Markdown
Member Author

Running as a draft to see/fix CI first. I had 100% pass on Windows, then accidentally reverted all my changes, and I haven't tested on Linux yet.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

zooba added 3 commits February 23, 2026 22:18
@zooba
Skip lint on unused imports
9ebb6a2
@zooba
Simulate missing _pyrepl for CI
44afb6a
@zooba
Revert "Simulate missing _pyrepl for CI"
f5e264a
This reverts commit 44afb6a.
@zooba

zooba commented Feb 23, 2026

Copy link
Copy Markdown
Member Author

First try :shipit: Reverting my little hack for hiding the module and will un-draft.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@zooba
zooba marked this pull request as ready for review February 23, 2026 23:00
@zooba
zooba requested review from 1st1, AA-Turner, FFY00, ambv, asvetlov, ericsnowcurrently, gaogaotiantian, kumaraditya303, lysnikolaou, pablogsal and willingc as code owners February 23, 2026 23:00
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 23, 2026
@zooba
Fix _sitebuiltins fallbacks
d7df609
@johnslavik
johnslavik self-requested a review February 24, 2026 00:09
ambv
ambv reviewed Feb 26, 2026
View reviewed changes
Comment thread Lib/_sitebuiltins.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@zooba

zooba commented Mar 3, 2026

Copy link
Copy Markdown
Member Author

@pablogsal Any concerns about this PR? (FWIW, I'll be maintaining the patch in my fork/backports anyway, this is just to make my[/my successor's] life easier by having the support in main as well.)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

FFY00
FFY00 approved these changes Mar 9, 2026
View reviewed changes

@FFY00 FFY00 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, this implementation seems okay to me. The only thing I could maybe suggest, is that it could make sense to move all the alternative necessary bits — such as the pager implementations — to a built-in module, providing the basic functionality. Though, I really have no strong feelings towards it.

That said, I believe this is a very welcome UX improvement, especially bundled with the other small UX improvements around initialization in 3.15.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

zooba reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 9, 2026
@ambv
ambv merged commit ae0d287 into python:main Mar 10, 2026
51 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 10, 2026
@zooba

zooba commented Mar 16, 2026

Copy link
Copy Markdown
Member Author

The only thing I could maybe suggest, is that it could make sense to move all the alternative necessary bits — such as the pager implementations — to a built-in module, providing the basic functionality.

Yeah, I considered this, but the refactoring started getting more invasive (plus it was only recently refactored in order to better support pyrepl, and I'm not trying to undo the new repl, just make things not break when it's missing).

FFY00 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@StanFromIreland StanFromIreland mentioned this pull request Apr 18, 2026
gh-145217: Add colour to pprint output #145218
Open
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@zooba @ljfp
pythongh-145035: Allows removing the _pyrepl module to completely dis…
4de82bc
…able the modern REPL (pythonGH-145159)
@zooba
zooba deleted the gh-145035 branch June 10, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv ambv left review comments
@FFY00 FFY00 FFY00 approved these changes
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@gaogaotiantian gaogaotiantian Awaiting requested review from gaogaotiantian gaogaotiantian is a code owner
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@johnslavik johnslavik Awaiting requested review from johnslavik

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@zooba @ambv @FFY00
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.