GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||
GeezerVison is showing github.com — gh-145035: Allows removing the _pyrepl module to completely disable the modern REPL by zooba · Pull Request #145159 · python/cpython Conversation
|
|
Running as a draft to see/fix CI first. I had 100% pass on Windows, then accidentally reverted all my changes, and I haven't tested on Linux yet. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
First try |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@pablogsal Any concerns about this PR? (FWIW, I'll be maintaining the patch in my fork/backports anyway, this is just to make my[/my successor's] life easier by having the support in |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
From what I can tell, this implementation seems okay to me. The only thing I could maybe suggest, is that it could make sense to move all the alternative necessary bits — such as the pager implementations — to a built-in module, providing the basic functionality. Though, I really have no strong feelings towards it.
That said, I believe this is a very welcome UX improvement, especially bundled with the other small UX improvements around initialization in 3.15.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Yeah, I considered this, but the refactoring started getting more invasive (plus it was only recently refactored in order to better support pyrepl, and I'm not trying to undo the new repl, just make things not break when it's missing). |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…able the modern REPL (pythonGH-145159)
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.