GeezerVison

Would appreciate review on this one next @freakboy3742

Would appreciate review on this one next @freakboy3742

Ack - I've been tied up with some other things at work. Will take a look as soon as I get a moment - probably early next week.

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

!buildbot emscripten

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 90f65ea 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F145180%2Fmerge

The command will test the builders whose names match following regular expression: emscripten

The builders matched are:

• WASM Emscripten PR

Looks like #145439 has broken CI for Emscripten; we'll need to fix that before landing this PR.

On the subject of which - add "adding Emscripten to GitHub CI" to the TODO list, as that will help avoid this sort of problem, and CI is otherwise stable.

!buildbot emscripten

🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 3b80a0b 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F145180%2Fmerge

The command will test the builders whose names match following regular expression: emscripten

The builders matched are:

• WASM Emscripten PR

!buildbot emscripten

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit b66e2fa 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F145180%2Fmerge

The command will test the builders whose names match following regular expression: emscripten

The builders matched are:

• WASM Emscripten PR

@hoodmane I guess the question is whether we backport this to 3.14. That would make updating the buildbot script easier...

Yes, please backport. Thanks @freakboy3742!

Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

GH-145582 is a backport of this pull request to the 3.14 branch.

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Arch Linux TraceRefs 3.14 (no tier) has failed when building commit ae6c211.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1747/builds/251) and take a look at the build logs.
4. Check if the failure is related to this commit (ae6c211) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1747/builds/251

Failed tests:

• test_urllib2net

Summary of the results of the build (if available):

==

remote: Enumerating objects: 19, done.        
remote: Counting objects:  10% (1/10)        
remote: Counting objects:  20% (2/10)        
remote: Counting objects:  30% (3/10)        
remote: Counting objects:  40% (4/10)        
remote: Counting objects:  50% (5/10)        
remote: Counting objects:  60% (6/10)        
remote: Counting objects:  70% (7/10)        
remote: Counting objects:  80% (8/10)        
remote: Counting objects:  90% (9/10)        
remote: Counting objects: 100% (10/10)        
remote: Counting objects: 100% (10/10), done.        
remote: Compressing objects:  20% (1/5)        
remote: Compressing objects:  40% (2/5)        
remote: Compressing objects:  60% (3/5)        
remote: Compressing objects:  80% (4/5)        
remote: Compressing objects: 100% (5/5)        
remote: Compressing objects: 100% (5/5), done.        
remote: Total 19 (delta 5), reused 5 (delta 5), pack-reused 9 (from 2)        
From https://github.com/python/cpython
 * branch                    3.14       -> FETCH_HEAD
Note: switching to 'ae6c211e98f8655598d666e5758a0a1a5f452837'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at ae6c211e98f [3.14] gh-145177: Support multiple Emscripten versions for Emscripten buildbot (GH-145180) (#145582)
Switched to and reset branch '3.14'

make: *** [Makefile:2496: buildbottest] Error 2