GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix unlikely potential reference leak in _locale._getdefaultlocale by serhiy-storchaka · Pull Request #145250 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Feb 26, 2026

Copy link
Copy Markdown
Member

It occurs in a code which perhaps never executed.

The bug was here from the beginning, from 8f017a0.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
Fix unlikely ptential reference leak in _locale._getdefaultlocale
ed49459 
It occurs in a code which perhaps never executed.
@serhiy-storchaka
serhiy-storchaka requested a review from malemburg February 26, 2026 11:54
@serhiy-storchaka serhiy-storchaka added skip news needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Feb 26, 2026
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 26, 2026
@serhiy-storchaka serhiy-storchaka changed the title Fix unlikely ptential reference leak in _locale._getdefaultlocale Fix unlikely potential reference leak in _locale._getdefaultlocale Feb 26, 2026
StanFromIreland
StanFromIreland approved these changes Feb 26, 2026
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@StanFromIreland StanFromIreland added the skip issue label Feb 26, 2026
@serhiy-storchaka serhiy-storchaka mentioned this pull request Feb 26, 2026
gh-123853: Cleanup Windows 95 locale fallback support #144738
Merged
@serhiy-storchaka
Merge branch 'main' into _locale-_getdefaultlocale-leak
d3cbe13
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) February 27, 2026 07:36
@serhiy-storchaka
serhiy-storchaka disabled auto-merge February 27, 2026 07:36
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) February 27, 2026 07:36
@serhiy-storchaka
serhiy-storchaka merged commit 6ea84b2 into python:main Feb 27, 2026
45 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Feb 27, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Feb 27, 2026
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 27, 2026
@serhiy-storchaka @miss-islington
Fix unlikely potential reference leak in _locale._getdefaultlocale (p…
7242e23 
…ythonGH-145250)

It occurs in a code which perhaps never executed.
(cherry picked from commit 6ea84b2)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 27, 2026
@serhiy-storchaka @miss-islington
Fix unlikely potential reference leak in _locale._getdefaultlocale (p…
4a4021b 
…ythonGH-145250)

It occurs in a code which perhaps never executed.
(cherry picked from commit 6ea84b2)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app

bedevere-app Bot commented Feb 27, 2026

Copy link
Copy Markdown

GH-145302 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Feb 27, 2026
@bedevere-app

bedevere-app Bot commented Feb 27, 2026

Copy link
Copy Markdown

GH-145303 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Feb 27, 2026
@serhiy-storchaka
serhiy-storchaka deleted the _locale-_getdefaultlocale-leak branch February 27, 2026 08:17
serhiy-storchaka added a commit that referenced this pull request Feb 27, 2026
@miss-islington @serhiy-storchaka
[3.14] Fix unlikely potential reference leak in _locale._getdefaultlo…
86c8467 
…cale (GH-145250) (GH-145302)

It occurs in a code which perhaps never executed.
(cherry picked from commit 6ea84b2)

Co-authored-by: Serhiy Storchaka <[email protected]>
brijkapadia pushed a commit to brijkapadia/cpython that referenced this pull request Feb 28, 2026
@serhiy-storchaka @brijkapadia
Fix unlikely potential reference leak in _locale._getdefaultlocale (p…
03ab030 
…ythonGH-145250)

It occurs in a code which perhaps never executed.
serhiy-storchaka added a commit that referenced this pull request Mar 24, 2026
@miss-islington @serhiy-storchaka
[3.13] Fix unlikely potential reference leak in _locale._getdefaultlo…
5a4959b 
…cale (GH-145250) (GH-145303)

It occurs in a code which perhaps never executed.
(cherry picked from commit 6ea84b2)

Co-authored-by: Serhiy Storchaka <[email protected]>
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@serhiy-storchaka @ljfp
Fix unlikely potential reference leak in _locale._getdefaultlocale (p…
0ea055e 
…ythonGH-145250)

It occurs in a code which perhaps never executed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland approved these changes
@malemburg malemburg Awaiting requested review from malemburg

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@serhiy-storchaka @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.