GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-145334: Make lazy import tests discoverable by johnslavik · Pull Request #145336 · python/cpython

Conversation

@johnslavik

@johnslavik johnslavik commented Feb 27, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: We don't run test_lazy_imports #145334

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@johnslavik
johnslavik requested review from DinoV, Yhg1s, brettcannon, ericsnowcurrently, ncoghlan, pablogsal and warsaw as code owners February 27, 2026 23:32
@bedevere-app bedevere-app Bot added the awaiting review label Feb 27, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Feb 27, 2026
We don't run test_lazy_imports #145334
Closed
@johnslavik johnslavik changed the title gh-145334: Move test_import.test_lazy_imports to test.test_lazy_import gh-145334: Move test.test_import.test_lazy_imports to test.test_lazy_import Feb 27, 2026
@johnslavik johnslavik added the skip news label Feb 27, 2026
@johnslavik

johnslavik commented Feb 27, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Conflicts. Sorry, I'll force-push this one time, practicality beats purity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@johnslavik
johnslavik marked this pull request as draft February 27, 2026 23:34
@bedevere-app bedevere-app Bot removed the awaiting review label Feb 27, 2026
@johnslavik
Move test.test_import.test_lazy_imports to test.test_lazy_import
78d584a
@johnslavik
johnslavik force-pushed the fix-test-layout-lazy-imports branch from cb2a385 to 78d584a Compare February 27, 2026 23:38
@johnslavik
johnslavik marked this pull request as ready for review February 27, 2026 23:38
@bedevere-app bedevere-app Bot added the awaiting review label Feb 27, 2026
@johnslavik
Update TESTSUBDIRS to match new layout
3c886f6
@johnslavik
johnslavik requested review from AA-Turner, emmatyping and erlend-aasland as code owners February 27, 2026 23:41
@johnslavik
Update CODEOWNERS
7fa84df
@johnslavik
johnslavik requested review from ezio-melotti, hugovk and webknjaz as code owners February 27, 2026 23:43
@johnslavik
Update Ruff ignore paths
d861d4d
@johnslavik
johnslavik requested a review from AlexWaygood as a code owner February 27, 2026 23:43
@AlexWaygood
AlexWaygood removed their request for review February 27, 2026 23:47
@brettcannon
brettcannon removed their request for review February 27, 2026 23:47
johnslavik added 4 commits February 28, 2026 00:48
@johnslavik
Add missing module to Ruff exclude paths
b101f5c
@johnslavik
Fix lazy imports to reflect new layout
4e382a6
@johnslavik
Fixup two more lazy imports
fcb0163
@johnslavik
Add @support.requires_subprocess() where necessary
d66c326
@johnslavik johnslavik changed the title gh-145334: Move test.test_import.test_lazy_imports to test.test_lazy_import gh-145334: Make lazy import tests discoverable Feb 28, 2026
pablogsal
pablogsal approved these changes Feb 28, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Feb 28, 2026
@pablogsal

pablogsal commented Feb 28, 2026

Copy link
Copy Markdown
Member

I have cloned this locally and run a bunch of checks to see that the new files make sense and we are not loosing anything here so I am satisfied. Thanks a lot @johnslavik! Great work 🥇
johnslavik reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Feb 28, 2026

Copy link
Copy Markdown
Member

We should test with an installed python because of the makefile changes. Will do this now
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Feb 28, 2026

Copy link
Copy Markdown
Member 
$ ./configure --prefix=$PWD/inst -C
$  make install -j
$ main fix-test-layout-lazy-imports ? ❯ ./inst/bin/python3 -m test test_lazy_import
Using random seed: 2114320666
0:00:00 load avg: 7.47 Run 1 test sequentially in a single process
0:00:00 load avg: 7.47 [1/1] test_lazy_import
BAR_MODULE_LOADED
0:00:00 load avg: 7.47 [1/1] test_lazy_import passed

== Tests result: SUCCESS ==

1 test OK.

Total duration: 655 ms
Total tests: run=91
Total test files: run=1/1
Result: SUCCESS
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Feb 28, 2026

Copy link
Copy Markdown
Member

We are golden
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal merged commit a66d518 into python:main Feb 28, 2026
49 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 28, 2026
brijkapadia pushed a commit to brijkapadia/cpython that referenced this pull request Feb 28, 2026
@johnslavik @brijkapadia
pythongh-145334: Make lazy import tests discoverable (python#145336)
2958b3c
@Yhg1s Yhg1s added the topic-lazy-imports label Mar 17, 2026
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@johnslavik @ljfp
pythongh-145334: Make lazy import tests discoverable (python#145336)
4b41b9a
@johnslavik
johnslavik deleted the fix-test-layout-lazy-imports branch July 21, 2026 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@Yhg1s Yhg1s Awaiting requested review from Yhg1s Yhg1s is a code owner
@DinoV DinoV Awaiting requested review from DinoV DinoV is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping is a code owner
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner
@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-lazy-imports

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@johnslavik @pablogsal @Yhg1s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.