GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||
GeezerVison is showing github.com — gh-145376: Fix various reference leaks by JelleZijlstra · Pull Request #145377 · python/cpython Conversation
|
|
Is there any improving the test suite to catch this kind of thing with the refleak bots? A quick glance suggests probably not, but it's worth at least getting a proper answer to the question written down :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I think a few of these could be caught with a test, yes. It doesn't feel extremely high value (these particular paths aren't likely to regress), but I can add some if you like. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I'm in no position to make that value judgement :). More test coverage is generally better, but if they're not worth it they're not worth it. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Thanks @JelleZijlstra for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry, @JelleZijlstra and @encukou, I could not cleanly backport this to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry, @JelleZijlstra and @encukou, I could not cleanly backport this to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
GH-145712 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
(cherry picked from commit bd13cc0) Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
(cherry picked from commit bd13cc0) Co-authored-by: Jelle Zijlstra <[email protected]>
|
GH-148661 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
(cherry picked from commit bd13cc0) Co-authored-by: Jelle Zijlstra <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.