GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-145376: Fix various reference leaks by JelleZijlstra · Pull Request #145377 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Mar 1, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

All found by Codex.

  • Issue: Various reference leaks in the core #145376

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@JelleZijlstra
pythongh-145376: Fix various reference leaks
c29f2ca
@JelleZijlstra
JelleZijlstra requested review from brettcannon, ericsnowcurrently, kumaraditya303, ncoghlan and warsaw as code owners March 1, 2026 00:48
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 1, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Mar 1, 2026
Various reference leaks in the core #145376
Closed
@JelleZijlstra JelleZijlstra added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Mar 1, 2026
kumaraditya303
kumaraditya303 approved these changes Mar 1, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 1, 2026
sergey-miryanov
sergey-miryanov approved these changes Mar 1, 2026
View reviewed changes
sobolevn
sobolevn reviewed Mar 1, 2026
View reviewed changes
Comment thread Python/crossinterp.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

@zware

zware commented Mar 1, 2026

Copy link
Copy Markdown
Member

Is there any improving the test suite to catch this kind of thing with the refleak bots? A quick glance suggests probably not, but it's worth at least getting a proper answer to the question written down :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JelleZijlstra

JelleZijlstra commented Mar 1, 2026

Copy link
Copy Markdown
Member Author

I think a few of these could be caught with a test, yes. It doesn't feel extremely high value (these particular paths aren't likely to regress), but I can add some if you like.

encukou reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@zware

zware commented Mar 2, 2026

Copy link
Copy Markdown
Member

I'm in no position to make that value judgement :). More test coverage is generally better, but if they're not worth it they're not worth it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@encukou
encukou merged commit bd13cc0 into python:main Mar 3, 2026
57 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington-app

miss-islington-app Bot commented Mar 3, 2026

Copy link
Copy Markdown

Thanks @JelleZijlstra for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 3, 2026
@miss-islington-app

miss-islington-app Bot commented Mar 3, 2026

Copy link
Copy Markdown

Sorry, @JelleZijlstra and @encukou, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker bd13cc09faaef01635aea85130f33aa8cbb8b177 3.14
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington-app miss-islington-app Bot assigned encukou Mar 3, 2026
@miss-islington-app

miss-islington-app Bot commented Mar 3, 2026

Copy link
Copy Markdown

Sorry, @JelleZijlstra and @encukou, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker bd13cc09faaef01635aea85130f33aa8cbb8b177 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app

bedevere-app Bot commented Mar 9, 2026

Copy link
Copy Markdown

GH-145712 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Mar 9, 2026
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Mar 9, 2026
@JelleZijlstra @StanFromIreland
[3.14] pythongh-145376: Fix various reference leaks (pythonGH-145377)
9db9080
(cherry picked from commit bd13cc0)

Co-authored-by: Jelle Zijlstra <[email protected]>
encukou pushed a commit that referenced this pull request Mar 10, 2026
@StanFromIreland @JelleZijlstra
[3.14] gh-145376: Fix various reference leaks (GH-145377) (GH-145712)
6d9221c
Co-authored-by: Jelle Zijlstra <[email protected]>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Apr 16, 2026
@JelleZijlstra @StanFromIreland
[3.13] pythongh-145376: Fix various reference leaks (pythonGH-145377)
73d767b
(cherry picked from commit bd13cc0)

Co-authored-by: Jelle Zijlstra <[email protected]>
@bedevere-app

bedevere-app Bot commented Apr 16, 2026

Copy link
Copy Markdown

GH-148661 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Apr 16, 2026
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@JelleZijlstra @ljfp
pythongh-145376: Fix various reference leaks (pythonGH-145377)
65bf9be
StanFromIreland added a commit that referenced this pull request May 12, 2026
@StanFromIreland @JelleZijlstra
[3.13] gh-145376: Fix various reference leaks (GH-145377) (#148661)
ea8c3e0
(cherry picked from commit bd13cc0)

Co-authored-by: Jelle Zijlstra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn left review comments
@sergey-miryanov sergey-miryanov sergey-miryanov approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@encukou encukou

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@JelleZijlstra @zware @sergey-miryanov @sobolevn @kumaraditya303 @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.