GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-145376: Fix null pointer deref in md5module.c by eendebakpt · Pull Request #145422 · python/cpython

gh-145376: Fix null pointer deref in md5module.c #145422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
picnixz merged 14 commits into python:main from eendebakpt:null_md5module
Mar 6, 2026

Uh oh!

There was an error while loading. Please reload this page.
Merged

gh-145376: Fix null pointer deref in md5module.c #145422

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d5b9513
Fix null pointer deref in md5module.c
eendebakpt Mar 2, 2026
6cc205c
pep7
eendebakpt Mar 2, 2026
330128f
review comments
eendebakpt Mar 2, 2026
aae8d22
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 2, 2026
c696867
Merge branch 'null_md5module' of github.com:eendebakpt/cpython into n…
eendebakpt Mar 2, 2026
eafcc2d
Merge branch 'main' into null_md5module
eendebakpt Mar 2, 2026
6b4cbff
Merge branch 'null_md5module' of github.com:eendebakpt/cpython into n…
eendebakpt Mar 2, 2026
3aa0033
fix
eendebakpt Mar 2, 2026
fe78d49
Merge branch 'main' into null_md5module
eendebakpt Mar 5, 2026
4ae295b
Apply suggestion from @vstinner
eendebakpt Mar 5, 2026
3e79541
Apply suggestion from @picnixz
eendebakpt Mar 5, 2026
1fa2e83
Apply suggestion from @eendebakpt
eendebakpt Mar 5, 2026
46b2511
Merge branch 'main' into null_md5module
eendebakpt Mar 5, 2026
93f1de5
Merge branch 'main' into null_md5module
picnixz Mar 6, 2026
File filter
Filter by extension
Clear filters
Conversations
Failed to load comments.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into null_md5module
  • Loading branch information

Uh oh!

There was an error while loading. Please reload this page.

@eendebakpt
eendebakpt committed Mar 5, 2026
commit fe78d49dac5c4979cc3a78ee657e8e1ff1098db8

There are no files selected for viewing

25 changes: 13 additions & 12 deletions 25 Modules/hmacmodule.c
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1452,18 +1452,19 @@ py_hmac_hinfo_ht_new(void)
assert(value->display_name == NULL);
value->refcnt = 0;

#define Py_HMAC_HINFO_LINK(KEY) \
do { \
int rc = py_hmac_hinfo_ht_add(table, KEY, value); \
if (rc < 0) { \
if (value->refcnt == 0) { \
PyMem_Free(value); \
} \
goto error; \
} \
else if (rc == 1) { \
value->refcnt++; \
} \
#define Py_HMAC_HINFO_LINK(KEY) \
do { \
int rc = py_hmac_hinfo_ht_add(table, (KEY), value); \
if (rc < 0) { \
/* entry may already be in ht, freed upon exit */ \
if (value->refcnt == 0) { \
PyMem_Free(value); \
} \
goto error; \
} \
else if (rc == 1) { \
value->refcnt++; \
} \
} while (0)
Py_HMAC_HINFO_LINK(e->name);
Py_HMAC_HINFO_LINK(e->hashlib_name);
Expand Down
Loading
Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

You are viewing a condensed version of this merge commit. You can view the full changes here.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.