GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-145376: Fix refleak in error path of time_tzset by eendebakpt · Pull Request #145477 · python/cpython

Conversation

@eendebakpt

@eendebakpt eendebakpt commented Mar 3, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Various reference leaks in the core #145376

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@eendebakpt
Fix refleak in error path of time_tzset
449e7a9
@eendebakpt
eendebakpt requested review from StanFromIreland, abalkin and pganssle as code owners March 3, 2026 14:56
@bedevere-app bedevere-app Bot mentioned this pull request Mar 3, 2026
Various reference leaks in the core #145376
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Mar 3, 2026
@eendebakpt eendebakpt added the skip news label Mar 3, 2026
johnslavik
johnslavik reviewed Mar 3, 2026
View reviewed changes
Comment thread Modules/timemodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@eendebakpt @johnslavik
Update Modules/timemodule.c
201f6f0 
Co-authored-by: Bartosz Sławecki <[email protected]>
StanFromIreland
StanFromIreland approved these changes Mar 3, 2026
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Mar 3, 2026
johnslavik
johnslavik approved these changes Mar 3, 2026
View reviewed changes
sergey-miryanov
sergey-miryanov approved these changes Mar 4, 2026
View reviewed changes
@encukou
encukou merged commit 3fe7849 into python:main Mar 4, 2026
49 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Mar 4, 2026
@pganssle

pganssle commented Mar 5, 2026

Copy link
Copy Markdown
Member

We have a buildbot or something that tests for refleaks, right? Is there a reason that this wasn't detected there? Is there a lack of test coverage?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sergey-miryanov

sergey-miryanov commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

Yeah, sometimes it is hard to test the fail path. Sometimes it is just an oversight.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eendebakpt
eendebakpt deleted the refleak_timemodule branch March 19, 2026 21:39
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@eendebakpt @ljfp
pythongh-145376: Fix refleak in error path of time_tzset (pythonGH-14…
3d0ab00 
…5477)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sergey-miryanov sergey-miryanov sergey-miryanov approved these changes
@johnslavik johnslavik johnslavik approved these changes
@StanFromIreland StanFromIreland StanFromIreland approved these changes
@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner
@abalkin abalkin Awaiting requested review from abalkin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@eendebakpt @pganssle @sergey-miryanov @johnslavik @StanFromIreland @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.