GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-145056: Accept frozendict in xml.etree by vstinner · Pull Request #145508 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Mar 4, 2026 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Element and SubElement of xml.etree.ElementTree now also accept frozendict as attrib.

  • Issue: Many pure python tools that have a special cases for dict should accept frozendict as well. #145056

📚 Documentation preview 📚: https://cpython-previews--145508.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-145056: Accept frozendict in xml.etree
5d0d438 
Element and SubElement of xml.etree.ElementTree now also accept
frozendict as attrib.
@vstinner vstinner added the skip news label Mar 4, 2026
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 4, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Mar 4, 2026
Many pure python tools that have a special cases for dict should accept frozendict as well. #145056
Open
@vstinner
Export _PyDict_CopyAsDict() function
e2e0533
@vstinner vstinner mentioned this pull request Mar 4, 2026
gh-141510: Always return a dict in PyDict_Copy() #145517
Closed
@vstinner
vstinner marked this pull request as draft March 4, 2026 20:22
@bedevere-app bedevere-app Bot removed the awaiting core review label Mar 4, 2026
@vstinner

vstinner commented Mar 4, 2026

Copy link
Copy Markdown
Member Author

I prefer to wait until #145517 is merged before merging this PR, so I mark this PR as a draft for now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner marked this pull request as ready for review March 5, 2026 11:53
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 5, 2026
@vstinner
vstinner merged commit 7bdfce0 into python:main Mar 5, 2026
53 of 54 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner deleted the frozendict_etree branch March 5, 2026 11:55
@bedevere-app bedevere-app Bot removed the awaiting core review label Mar 5, 2026
@vstinner

vstinner commented Mar 5, 2026

Copy link
Copy Markdown
Member Author

I prefer to wait until #145517 is merged before merging this PR, so I mark this PR as a draft for now.

The situation looks more complicated than what I expected. So I merged this change with the temporary solution: _PyDict_CopyAsDict() function.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@vstinner @ljfp
pythongh-145056: Accept frozendict in xml.etree (python#145508)
d6294fc 
Element and SubElement of xml.etree.ElementTree now also accept
frozendict for attrib.

Export _PyDict_CopyAsDict() function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.