GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-145376: Fix reference leak in _lprof.c by eendebakpt · Pull Request #145539 · python/cpython

Conversation

@eendebakpt

@eendebakpt eendebakpt commented Mar 5, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Skipping news. This only affects cases where people manually replace the sys.monitoring.MISSING sentinel.

  • Issue: Various reference leaks in the core #145376

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@eendebakpt
Fix reference leak in _lprof.c
bf4d84b
@bedevere-app bedevere-app Bot mentioned this pull request Mar 5, 2026
Various reference leaks in the core #145376
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Mar 5, 2026
@eendebakpt eendebakpt added the skip news label Mar 5, 2026
vstinner
vstinner approved these changes Mar 5, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The get_cfunc_from_callable() fix is surprising: PyCFunction_Check() is always true and so nobody noticed the reference leak before? Is it possible to trigger the leak with a reproducer?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Mar 5, 2026
kumaraditya303
kumaraditya303 approved these changes Mar 7, 2026
View reviewed changes
@eendebakpt

eendebakpt commented Mar 8, 2026

Copy link
Copy Markdown
Contributor Author

LGTM.

The get_cfunc_from_callable() fix is surprising: PyCFunction_Check() is always true and so nobody noticed the reference leak before? Is it possible to trigger the leak with a reproducer?

I cannot create a reproducer from the Python side. The check Py_TYPE(callable) == &PyMethodDescr_Type ensures callable->tp_descr_get is always method_get from descrobject.c which (currently) returns a PyCFunction_Type instance or NULL.

A C-extension could override the tp_descr_get field (override as in setting a new tp_descr_get, not subclassing PyMethodDescr_Type) and return a non-PyCFunction_Type object, but under the consenting adult principle I do not think we have to guard for that.

I can leave this part as is, change the PyCFunction_Check into an assert or revert to the current main version.

Pinging @gaogaotiantian as the one who introduced the code in #103534

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
vstinner merged commit 201e183 into python:main Mar 9, 2026
56 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 9, 2026
@vstinner

vstinner commented Mar 9, 2026

Copy link
Copy Markdown
Member

Merged. Thanks for the fix.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@eendebakpt
eendebakpt deleted the refleak_lsprof branch March 19, 2026 21:39
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@eendebakpt @ljfp
pythongh-145376: Fix reference leaks in _lprof.c (python#145539)
0a85ed2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@eendebakpt @vstinner @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.