GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-116738: Make mmap.set_name thread-safe by aisk · Pull Request #145555 · python/cpython

Conversation

@aisk

@aisk aisk commented Mar 5, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

mmap.resize may update the pointer to data and size, which is under the protection of a critical section.

In mmap.set_name, it uses data and size to annotate the mmap, but it does not have a critical section around it. So it may use an invalid data and size combination, which may have problems.

  • Issue: Audit all built-in modules for thread safety #116738

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
aisk added 2 commits March 6, 2026 01:33
@aisk
Add critical section around mmap.set_name to make it thread-safe
06dac9c
@aisk
Add news entry
795039c
@bedevere-app bedevere-app Bot mentioned this pull request Mar 5, 2026
Audit all built-in modules for thread safety #116738
Open
@bedevere-app bedevere-app Bot added the awaiting review label Mar 5, 2026
@vstinner

vstinner commented Mar 5, 2026

Copy link
Copy Markdown
Member

cc @corona10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10 corona10 self-assigned this Mar 5, 2026
aisk
aisk commented Mar 6, 2026
View reviewed changes
Comment thread Misc/NEWS.d/next/Core_and_Builtins/2026-03-06-01-36-20.gh-issue-116738.OWVWRx.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@aisk
Apply suggestion from @aisk
a768415
vstinner
vstinner approved these changes Mar 6, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It sounds reasonable to add a critical section to get a consistent view of the memory mapping.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Mar 6, 2026
corona10
corona10 approved these changes Mar 7, 2026
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
corona10 merged commit 46761c9 into python:main Mar 7, 2026
54 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 7, 2026
@aisk
aisk deleted the mmap-set-name-thread-safe branch March 8, 2026 02:37
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@aisk @ljfp
pythongh-116738: Make mmap.set_name thread-safe (python#145555)
ed62766 
* Add critical section around mmap.set_name to make it thread-safe

* Add news entry

* Apply suggestion from @aisk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@corona10 corona10 corona10 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@corona10 corona10

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@aisk @vstinner @corona10
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.