GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-143055: Fix crash in AST unparser when unparsing dict comprehension unpacking by StanFromIreland · Pull Request #145556 · python/cpython

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Mar 5, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member 
>>> from __future__ import annotations
... 
... spam: {**x for x in ()}
... 
Segmentation fault (core dumped)

Found by OSS Fuzz in #489790200.

  • Issue: Implement PEP 798 – Unpacking in Comprehensions #143055

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
StanFromIreland added 2 commits March 5, 2026 16:25
@StanFromIreland
Fix crash in AST unparser when unparsing dict comprehension unpacking
7fdeed5
@StanFromIreland
I was overthinking it.
78adfb8
@StanFromIreland
StanFromIreland requested review from AA-Turner, Eclips4, JelleZijlstra, hugovk, isidentical and tomasr8 as code owners March 5, 2026 16:39
@bedevere-app bedevere-app Bot mentioned this pull request Mar 5, 2026
Implement PEP 798 – Unpacking in Comprehensions #143055
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Mar 5, 2026
JelleZijlstra
JelleZijlstra reviewed Mar 5, 2026
View reviewed changes
Comment thread Lib/test/test_future_stmt/test_future.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland
test list comp too
727721a
@StanFromIreland
StanFromIreland requested a review from JelleZijlstra March 5, 2026 16:54
@StanFromIreland

This comment was marked as outdated.

Sign in to view
@StanFromIreland
Merge branch 'main' into dict-comp-unparse
e3d8248
@StanFromIreland
StanFromIreland requested a review from gpshead March 6, 2026 15:38
JelleZijlstra
JelleZijlstra reviewed Mar 9, 2026
View reviewed changes
Comment thread Lib/test/test_unparse.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland
Add Python test too
316ca30
@StanFromIreland
StanFromIreland requested a review from JelleZijlstra March 9, 2026 16:22
JelleZijlstra
JelleZijlstra approved these changes Mar 9, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Mar 9, 2026
@JelleZijlstra
JelleZijlstra merged commit 255e79f into python:main Mar 9, 2026
54 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 9, 2026
@StanFromIreland
StanFromIreland deleted the dict-comp-unparse branch March 9, 2026 17:37
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@StanFromIreland @ljfp
pythongh-143055: Fix crash in AST unparser when unparsing dict compre…
2a6a86f 
…hension unpacking (python#145556)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@isidentical isidentical Awaiting requested review from isidentical isidentical is a code owner
@Eclips4 Eclips4 Awaiting requested review from Eclips4 Eclips4 is a code owner
@tomasr8 tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner
@gpshead gpshead Awaiting requested review from gpshead

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@StanFromIreland @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.