GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-145219: Emscripten bld configurable directory & only clean Emscripten by hoodmane · Pull Request #145581 · python/cpython

Conversation

@hoodmane

@hoodmane hoodmane commented Mar 6, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Two small changes to the Emscripten build script:

  1. Make clean only delete the parts of cross-build that are emscripten specific
  2. Make the cross-build name configurable

cc @freakboy3742.

  • Issue: Improvements to Emscripten build script #145219

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hoodmane
hoodmane requested review from emmatyping and freakboy3742 as code owners March 6, 2026 10:01
@bedevere-app bedevere-app Bot mentioned this pull request Mar 6, 2026
Improvements to Emscripten build script #145219
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Mar 6, 2026
@hoodmane
hoodmane force-pushed the configurable-cross-build-dir branch from 61484f5 to 61bbce7 Compare March 6, 2026 10:07
@hoodmane hoodmane added skip news needs backport to 3.14 bugs and security fixes labels Mar 6, 2026
@hoodmane
pythongh-145219: Emscripten bld configurable directory & only clean E…
a124b32 
…mscripten

Two small changes to the Emscripten build script:
1. Make clean only delete the parts of cross-build that are emscripten specific
2. Make the cross-build name configurable
@hoodmane
hoodmane force-pushed the configurable-cross-build-dir branch from 61bbce7 to a124b32 Compare March 6, 2026 10:13
@freakboy3742

freakboy3742 commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

!buildbot emscripten
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Mar 9, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit a124b32 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F145581%2Fmerge

The command will test the builders whose names match following regular expression: emscripten

The builders matched are:

  • WASM Emscripten PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
freakboy3742 added 3 commits March 9, 2026 09:56
@freakboy3742
Allow for a full clean.
8c93331
@freakboy3742
Ensure cross-build path is interpreted absolute.
26f99dc
@freakboy3742
Broaden the cross-build ignore pattern to allow for parallel cross-bu…
084133a 
…ilds.
@freakboy3742

freakboy3742 commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

!buildbot emscripten
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Mar 9, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 084133a 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F145581%2Fmerge

The command will test the builders whose names match following regular expression: emscripten

The builders matched are:

  • WASM Emscripten PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
freakboy3742
freakboy3742 approved these changes Mar 9, 2026
View reviewed changes

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; I've pushed one small feature (being able to optionally clean build as well), and one bug (resolving the user-provided cross-build path) fix; with those, we should be good to go.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Tools/wasm/emscripten/__main__.py Outdated
"""Compute all build paths from the given cross-build directory."""
if cross_build_dir is None:
cross_build_dir = DEFAULT_CROSS_BUILD_DIR
cross_build_dir = Path(cross_build_dir)

@freakboy3742 freakboy3742 Mar 9, 2026

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path needs to be resolved or a value of ./cross-build-3.15 will fail:

Suggested change
cross_build_dir = Path(cross_build_dir)
cross_build_dir = Path(cross_build_dir).absolute()

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Mar 9, 2026
@freakboy3742
freakboy3742 enabled auto-merge (squash) March 9, 2026 02:09
@freakboy3742
freakboy3742 merged commit 0156133 into python:main Mar 9, 2026
49 of 50 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 9, 2026
@miss-islington-app

miss-islington-app Bot commented Mar 9, 2026

Copy link
Copy Markdown

Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 9, 2026
@hoodmane @freakboy3742 @miss-islington
pythongh-145219: Add Emscripten cross-build and clean configurability (…
1f64904 
…pythonGH-145581)

Modifies the Emscripten build script to allow for custom cross-build directory
names, and to only clean Emscripten-specific paths (optionally including the
build python).
(cherry picked from commit 0156133)

Co-authored-by: Hood Chatham <[email protected]>
Co-authored-by: Russell Keith-Magee <[email protected]>
@bedevere-app

bedevere-app Bot commented Mar 9, 2026

Copy link
Copy Markdown

GH-145654 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Mar 9, 2026
freakboy3742 added a commit that referenced this pull request Mar 9, 2026
@miss-islington @hoodmane @freakboy3742
[3.14] gh-145219: Add Emscripten cross-build and clean configurability (
b194688 
GH-145581) (#145654)

Modifies the Emscripten build script to allow for custom cross-build directory
names, and to only clean Emscripten-specific paths (optionally including the
build python).
(cherry picked from commit 0156133)

Co-authored-by: Hood Chatham <[email protected]>
Co-authored-by: Russell Keith-Magee <[email protected]>
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@hoodmane @freakboy3742 @ljfp
pythongh-145219: Add Emscripten cross-build and clean configurability (…
c09d050 
…python#145581)

Modifies the Emscripten build script to allow for custom cross-build directory
names, and to only clean Emscripten-specific paths (optionally including the
build python).

Co-authored-by: Russell Keith-Magee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes
@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hoodmane @freakboy3742 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.