GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-141510: Optimize frozendict(frozendict) by vstinner · Pull Request #145592 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Mar 6, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Return the same object unmodified if it's exactly the frozendict type.

  • Issue: PEP 814: Add built-in frozendict type #141510

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jorenham and soltanoff reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@vstinner
pythongh-141510: Optimize frozendict(frozendict)
99d7ca6 
Return the same object unmodified if it's exactly the frozendict
type.
@vstinner
vstinner requested review from markshannon and methane as code owners March 6, 2026 15:47
@vstinner vstinner added the skip news label Mar 6, 2026
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 6, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Mar 6, 2026
PEP 814: Add built-in frozendict type #141510
Closed
@vstinner

vstinner commented Mar 6, 2026

Copy link
Copy Markdown
Member Author

cc @encukou
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
Optimize also PyFrozenDict_New(frozendict)
5b07811
encukou
encukou reviewed Mar 6, 2026
View reviewed changes
Comment thread Objects/dictobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
Document PyFrozenSet_New() optimization
114ffb5
@vstinner
vstinner requested a review from ZeroIntensity as a code owner March 6, 2026 16:34
vstinner added 2 commits March 6, 2026 22:37
@vstinner
Simplify the doc; omit subclass special case
9de1f08
@vstinner
Remove the note in PyFrozenDict_New() doc
ca20231
kumaraditya303
kumaraditya303 approved these changes Mar 9, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 9, 2026
@vstinner
vstinner merged commit 0dfe649 into python:main Mar 9, 2026
52 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner deleted the frozendict_new_same branch March 9, 2026 14:47
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 9, 2026
@vstinner

vstinner commented Mar 9, 2026

Copy link
Copy Markdown
Member Author

Merged. Thanks for reviews.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@vstinner @ljfp
pythongh-141510: Optimize frozendict(frozendict) (python#145592)
ddec0f3 
Return the same object unmodified if it's exactly the frozendict
type.

Optimize also PyFrozenDict_New(frozendict).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@methane methane Awaiting requested review from methane methane is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@ZeroIntensity ZeroIntensity Awaiting requested review from ZeroIntensity

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @encukou @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.