GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||
GeezerVison is showing github.com — gh-145616: Detect Android sysconfig ABI correctly on 32-bit ARM Android on 64-bit ARM kernel by robertkirkman · Pull Request #145617 · python/cpython Conversation
|
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks, I'll look at this in the next few days. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I have provided additional follow-up information here |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks fine, but please also update the corresponding code in test_get_platform in test_sysconfig.py.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
… Android on 64-bit ARM kernel - When Python is running on 32-bit ARM Android on a 64-bit ARM kernel, `os.uname().machine` is `armv8l`. Such devices run the same userspace code as `armv7l` devices, so apply the same `armeabi_v7a` Android ABI to them, which works. - Issue: python#145616
eb69366 to
b01cf02
Compare
|
Thank you for pointing that out, I didn't notice that code previously. I hope I've updated it correctly now. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Also, pardon me for asking, but when you put the "needs backport to 3.13" and "needs backport to 3.14" labels on this, does that mean that I should open follow-up PRs afterward targeting those branches of Python, or will you do that? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
No need, it will be done automatically by a bot when this PR is merged, which I hope @encukou can do now.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Thanks @robertkirkman for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
… Android on 64-bit ARM kernel (pythonGH-145617) When Python is running on 32-bit ARM Android on a 64-bit ARM kernel, `os.uname().machine` is `armv8l`. Such devices run the same userspace code as `armv7l` devices, so apply the same `armeabi_v7a` Android ABI to them, which works. (cherry picked from commit 3a2b81e) Co-authored-by: Robert Kirkman <[email protected]>
|
Sorry, @robertkirkman and @encukou, I could not cleanly backport this to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
GH-146464 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…M Android on 64-bit ARM kernel (GH-145617) (#146464) gh-145616: Detect Android sysconfig ABI correctly on 32-bit ARM Android on 64-bit ARM kernel (GH-145617) When Python is running on 32-bit ARM Android on a 64-bit ARM kernel, `os.uname().machine` is `armv8l`. Such devices run the same userspace code as `armv7l` devices, so apply the same `armeabi_v7a` Android ABI to them, which works. (cherry picked from commit 3a2b81e) Co-authored-by: Robert Kirkman <[email protected]>
…bit ARM Android on 64-bit ARM kernel (pythonGH-145617) When Python is running on 32-bit ARM Android on a 64-bit ARM kernel, `os.uname().machine` is `armv8l`. Such devices run the same userspace code as `armv7l` devices, so apply the same `armeabi_v7a` Android ABI to them, which works. (cherry picked from commit 3a2b81e) Co-authored-by: Robert Kirkman <[email protected]>
|
GH-146539 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…M Android on 64-bit ARM kernel (GH-145617) (#146539) When Python is running on 32-bit ARM Android on a 64-bit ARM kernel, `os.uname().machine` is `armv8l`. Such devices run the same userspace code as `armv7l` devices, so apply the same `armeabi_v7a` Android ABI to them, which works. (cherry picked from commit 3a2b81e) Co-authored-by: Robert Kirkman <[email protected]>
… Android on 64-bit ARM kernel (pythonGH-145617) When Python is running on 32-bit ARM Android on a 64-bit ARM kernel, `os.uname().machine` is `armv8l`. Such devices run the same userspace code as `armv7l` devices, so apply the same `armeabi_v7a` Android ABI to them, which works.
… Android on 64-bit ARM kernel (pythonGH-145617) When Python is running on 32-bit ARM Android on a 64-bit ARM kernel, `os.uname().machine` is `armv8l`. Such devices run the same userspace code as `armv7l` devices, so apply the same `armeabi_v7a` Android ABI to them, which works.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
pip install does not work in Python 3.13 on 32-bit ARM Android running on 64-bit ARM kernel
There was an error while loading. Please reload this page.