GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-145736: Fix Tkinter tests for Tk 8.7, 9.0 and 9.1 by serhiy-storchaka · Pull Request #145738 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Mar 10, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Tkinter tests fail with Tk 8.7, 9.0 and 9.1 #145736

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-145736: Fix Tkinter tests for Tk 8.7, 9.0 and 9.1
77f1905
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.14 bugs and security fixes labels Mar 10, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Mar 10, 2026
Tkinter tests fail with Tk 8.7, 9.0 and 9.1 #145736
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 10, 2026
serhiy-storchaka added 5 commits March 10, 2026 13:33
@serhiy-storchaka
Clean up more tests.
2fb92a3
@serhiy-storchaka
Clean up yet more tests.
65843f7
@serhiy-storchaka
Merge branch 'main' into test-tkinter-8.7
b9f8b58
@serhiy-storchaka
Clean up even more tests.
382543d
@serhiy-storchaka
Fix tests for Tk 9.0.0 and 9.0.1.
2140325
@serhiy-storchaka serhiy-storchaka added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 11, 2026
@bedevere-bot

bedevere-bot commented Mar 11, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 2140325 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F145738%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 11, 2026
@serhiy-storchaka
serhiy-storchaka merged commit 77d6d5d into python:main Mar 11, 2026
114 of 115 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Mar 11, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Mar 11, 2026
@serhiy-storchaka
serhiy-storchaka deleted the test-tkinter-8.7 branch March 11, 2026 19:01
@miss-islington-app

miss-islington-app Bot commented Mar 11, 2026

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 77d6d5d8fcc8565034dac378b2184131af735512 3.14
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned serhiy-storchaka Mar 11, 2026
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Mar 11, 2026
@serhiy-storchaka
[3.14] pythongh-145736: Fix Tkinter tests for Tk 8.7, 9.0 and 9.1 (py…
e003800 
…thonGH-145738)

(cherry picked from commit 77d6d5d)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app

bedevere-app Bot commented Mar 11, 2026

Copy link
Copy Markdown

GH-145841 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Mar 11, 2026
serhiy-storchaka added a commit that referenced this pull request Mar 12, 2026
@serhiy-storchaka
[3.14] gh-145736: Fix Tkinter tests for Tk 8.7, 9.0 and 9.1 (GH-145738)…
a778fd6 
… (GH-145841)

(cherry picked from commit 77d6d5d)
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@serhiy-storchaka @ljfp
pythongh-145736: Fix Tkinter tests for Tk 8.7, 9.0 and 9.1 (pythonGH-…
3d5cd22 
…145738)
This was referenced Jul 10, 2026
test_tkinter failing on MacOS #128846
Closed
[3.13] gh-128846: Make tkinter tests robust against Tcl/Tk 9.0 #153484
Merged
serhiy-storchaka added a commit that referenced this pull request Jul 11, 2026
@serhiy-storchaka
[3.13] gh-128846: Make tkinter tests robust against Tcl/Tk 9.0 (GH-15…
59e183c 
…3484)

Backport the test-only parts of the Tcl/Tk 8.7/9.0/9.1 test adaptations so
that test_tkinter and test_ttk pass when Python 3.13 is built against
Tcl/Tk 9.0 (for example the Homebrew build used on macOS), while still
passing against the Tcl/Tk 8.6 that 3.13 ships.

Combines the test changes from:

* gh-124111: Update tkinter for compatibility with Tcl/Tk 9.0.0 (GH-124156)
* gh-124111: test macOS CI with Tk 9 (GH-137424)
* gh-145736: Fix Tkinter tests for Tk 8.7, 9.0 and 9.1 (GH-145738)

The corresponding non-test changes (Modules/_tkinter.c, Lib/tkinter/ttk.py,
PCbuild and CI configuration) are not backported.
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@serhiy-storchaka @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.