GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-145743: Fix inconsistency after calling Struct.__init__() with invalid format by serhiy-storchaka · Pull Request #145744 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Mar 10, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Only set the format attribute after successful (re-)initialization.

  • Issue: Struct.__init__() can leave the Struct object in inconsistent state #145743

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-145743: Fix inconsistancy after calling Struct.__init__() wi…
7336aaa 
…th invalid format

Only set the format attribute after successful (re-)initialization.
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes skip news labels Mar 10, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Mar 10, 2026
Struct.__init__() can leave the Struct object in inconsistent state #145743
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 10, 2026
@serhiy-storchaka serhiy-storchaka mentioned this pull request Mar 10, 2026
gh-143715: Deprecate incomplete initialization of struct.Struct() #145580
Merged
vstinner
vstinner approved these changes Mar 10, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/_struct.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 10, 2026
@vstinner vstinner changed the title gh-145743: Fix inconsistancy after calling Struct.__init__() with invalid format gh-145743: Fix inconsistency after calling Struct.__init__() with invalid format Mar 10, 2026
@serhiy-storchaka @vstinner
Update Modules/_struct.c
a23f9bb 
Co-authored-by: Victor Stinner <[email protected]>
@serhiy-storchaka
serhiy-storchaka merged commit 3f33bf8 into python:main Mar 10, 2026
48 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 10, 2026
@miss-islington-app

miss-islington-app Bot commented Mar 10, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka deleted the struct-reinitialization-consistency branch March 10, 2026 16:29
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 10, 2026
@serhiy-storchaka @miss-islington
pythongh-145743: Fix inconsistency after calling Struct.__init__() wi…
6ab0473 
…th invalid format (pythonGH-145744)

Only set the format attribute after successful (re-)initialization.
(cherry picked from commit 3f33bf8)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 10, 2026
@serhiy-storchaka @miss-islington
pythongh-145743: Fix inconsistency after calling Struct.__init__() wi…
c9ade5e 
…th invalid format (pythonGH-145744)

Only set the format attribute after successful (re-)initialization.
(cherry picked from commit 3f33bf8)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app

bedevere-app Bot commented Mar 10, 2026

Copy link
Copy Markdown

GH-145763 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Mar 10, 2026
@bedevere-app

bedevere-app Bot commented Mar 10, 2026

Copy link
Copy Markdown

GH-145764 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Mar 10, 2026
serhiy-storchaka added a commit that referenced this pull request Mar 10, 2026
@miss-islington @serhiy-storchaka
[3.13] gh-145743: Fix inconsistency after calling Struct.__init__() w…
b5082d8 
…ith invalid format (GH-145744) (GH-145764)

Only set the format attribute after successful (re-)initialization.
(cherry picked from commit 3f33bf8)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Mar 10, 2026
@miss-islington @serhiy-storchaka
[3.14] gh-145743: Fix inconsistency after calling Struct.__init__() w…
7e38926 
…ith invalid format (GH-145744) (GH-145763)

Only set the format attribute after successful (re-)initialization.
(cherry picked from commit 3f33bf8)

Co-authored-by: Serhiy Storchaka <[email protected]>
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@serhiy-storchaka @ljfp
pythongh-145743: Fix inconsistency after calling Struct.__init__() wi…
1c1c04c 
…th invalid format (pythonGH-145744)

Only set the format attribute after successful (re-)initialization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@serhiy-storchaka @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.