GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-145376: Fix GC tracking in structseq.__replace__ by eendebakpt · Pull Request #145820 · python/cpython

Conversation

@eendebakpt

@eendebakpt eendebakpt commented Mar 11, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Various reference leaks in the core #145376

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
eendebakpt added 4 commits March 11, 2026 14:57
@eendebakpt
Fix bug in tracking of structseq
d279067
@eendebakpt
add test
bf01d4c
@eendebakpt
pep8
0d3d149
@eendebakpt
pep8
0b54103
@eendebakpt
eendebakpt requested a review from markshannon as a code owner March 11, 2026 14:07
@bedevere-app bedevere-app Bot added the awaiting review label Mar 11, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Mar 11, 2026
Various reference leaks in the core #145376
Closed
eendebakpt and others added 3 commits March 11, 2026 15:08
@eendebakpt
Merge branch 'structseq_tracking' of github.com:eendebakpt/cpython in…
c6040c6
…to structseq_tracking
@eendebakpt
revert unrelated changes
3bd205f
@blurb-it
📜🤖 Added by blurb_it.
2e04864
vstinner
vstinner approved these changes Mar 13, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Mar 13, 2026
vstinner
vstinner reviewed Mar 13, 2026
View reviewed changes
Comment thread Misc/NEWS.d/next/Core_and_Builtins/2026-03-11-21-27-28.gh-issue-145376.LfDvyw.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@eendebakpt @vstinner
Update Misc/NEWS.d/next/Core_and_Builtins/2026-03-11-21-27-28.gh-issu…
d786df3
…e-145376.LfDvyw.rst

Co-authored-by: Victor Stinner <[email protected]>
kumaraditya303
kumaraditya303 approved these changes Mar 13, 2026
View reviewed changes
@kumaraditya303
kumaraditya303 enabled auto-merge (squash) March 13, 2026 15:03
@kumaraditya303 kumaraditya303 added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Mar 13, 2026
@kumaraditya303
kumaraditya303 merged commit 00a2585 into python:main Mar 13, 2026
54 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington-app

miss-islington-app Bot commented Mar 13, 2026

Copy link
Copy Markdown

Thanks @eendebakpt for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 13, 2026
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 13, 2026
@eendebakpt @miss-islington
pythongh-145376: Fix GC tracking in structseq.__replace__ (pythonGH…
84212fd
…-145820)

(cherry picked from commit 00a2585)

Co-authored-by: Pieter Eendebak <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 13, 2026
@eendebakpt @miss-islington
pythongh-145376: Fix GC tracking in structseq.__replace__ (pythonGH…
ad994fd
…-145820)

(cherry picked from commit 00a2585)

Co-authored-by: Pieter Eendebak <[email protected]>
@bedevere-app

bedevere-app Bot commented Mar 13, 2026

Copy link
Copy Markdown

GH-145922 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Mar 13, 2026
@bedevere-app

bedevere-app Bot commented Mar 13, 2026

Copy link
Copy Markdown

GH-145924 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Mar 13, 2026
kumaraditya303 pushed a commit that referenced this pull request Mar 16, 2026
@miss-islington @eendebakpt
[3.14] gh-145376: Fix GC tracking in structseq.__replace__ (GH-145820…
cccd9dd
…) (#145922)

gh-145376: Fix GC tracking in `structseq.__replace__` (GH-145820)
(cherry picked from commit 00a2585)

Co-authored-by: Pieter Eendebak <[email protected]>
kumaraditya303 pushed a commit that referenced this pull request Mar 16, 2026
@miss-islington @eendebakpt
[3.13] gh-145376: Fix GC tracking in structseq.__replace__ (GH-145820…
1d6e037
…) (#145924)

gh-145376: Fix GC tracking in `structseq.__replace__` (GH-145820)
(cherry picked from commit 00a2585)

Co-authored-by: Pieter Eendebak <[email protected]>
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@eendebakpt @ljfp
pythongh-145376: Fix GC tracking in structseq.__replace__ (python#1…
245f2ac
…45820)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@markshannon markshannon Awaiting requested review from markshannon

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@eendebakpt @vstinner @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.