GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-145917: Add MIME types for TTC and Haptics formats by clin1234 · Pull Request #145918 · python/cpython

Conversation

@clin1234

@clin1234 clin1234 commented Mar 13, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Add MIME types for TTC and Haptics formats #145917

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@clin1234
clin1234 requested a review from a team as a code owner March 13, 2026 14:19
@bedevere-app bedevere-app Bot added the awaiting review label Mar 13, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Mar 13, 2026
Add MIME types for TTC and Haptics formats #145917
Closed
@clin1234
clin1234 requested a review from AA-Turner as a code owner March 13, 2026 14:27
@clin1234

clin1234 commented Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

@StanFromIreland, @hugovk, @benediktjohannes, @encukou: would any one of you review #146344, #146342, and this? I would like for all three to be merged in before the beta cutoff.

Apologies if I sound a bit pushy.
benediktjohannes reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benediktjohannes
benediktjohannes reviewed Apr 1, 2026
View reviewed changes
Comment thread Doc/whatsnew/3.15.rst Outdated

@benediktjohannes benediktjohannes Apr 1, 2026

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we maybe combine the list in one because both lists were authored by you?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@clin1234 clin1234 Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@benediktjohannes benediktjohannes Apr 1, 2026

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We then need to write „and gh …“

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
benediktjohannes
benediktjohannes reviewed Apr 1, 2026
View reviewed changes
Comment thread Lib/mimetypes.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
benediktjohannes
benediktjohannes reviewed Apr 1, 2026
View reviewed changes
Comment thread Lib/mimetypes.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
benediktjohannes
benediktjohannes reviewed Apr 1, 2026
View reviewed changes
Comment thread Lib/mimetypes.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
benediktjohannes
benediktjohannes reviewed Apr 1, 2026
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2026-03-13-14-23-33.gh-issue-145917.TooGKx.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@benediktjohannes

benediktjohannes commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

@StanFromIreland, @hugovk, @benediktjohannes, @encukou: would any one of you review #146344, #146342, and this? I would like for all three to be merged in before the beta cutoff.

Apologies if I sound a bit pushy.

No problem! Overall looks pretty good to me, nice contributions, thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benediktjohannes
benediktjohannes reviewed Apr 1, 2026
View reviewed changes

@benediktjohannes benediktjohannes left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking pretty good to me! I did not look up the correctness of the applications and the entrys in official databases, but I can‘t approve the changes either because of permissions, so from what I saw when having a look on it, this LGTM, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@benediktjohannes

benediktjohannes commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Please also fix Bullet list ends without a blank line; unexpected unindent
encukou reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benediktjohannes
benediktjohannes reviewed Apr 11, 2026
View reviewed changes

@benediktjohannes benediktjohannes left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nitpick

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Misc/NEWS.d/next/Library/2026-03-13-14-23-33.gh-issue-145917.TooGKx.rst Outdated
@@ -0,0 +1,8 @@
* Add the following to ``mimetypes``:

@benediktjohannes benediktjohannes Apr 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think that in this news entry (where it is not 3.15.rst) the „“ is not necessary because this file itself is considered to be one entry in a list and therefore the „“ is then added automatically, but I may be mistaken. This also needs to be changed in the other PRs please. And also the contributor statement and potentially other elements which were moved to the right (due to this change) might need to get back again, please. But I might be mistaken. Is there any unit test suggesting this change?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@benediktjohannes benediktjohannes Apr 11, 2026

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way: The rest looks quite good to me from a Short Overview, thank You very much for contributing!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@benediktjohannes

benediktjohannes commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Thank you very much, looks great to me!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@benediktjohannes

benediktjohannes commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

(I have not checked all mime types for correctness (e.g. typing, …) but just had a overview look on the PR in general, but based on my short review, I think that this is nice!)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@benediktjohannes

benediktjohannes commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Unforetunately, we got (at least one) failing Check, but this first one seems to be unrelated, but please also have a look lateron on the potentially failing Checks whether they Are related or not because I didn’t Check on Small things Like Syntax
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@clin1234
clin1234 force-pushed the patch-4 branch from ce5f4dd to 7d6da03 Compare April 16, 2026 20:41
@clin1234
clin1234 requested review from AlexWaygood, FFY00, JelleZijlstra, ambv, berkerpeksag, emmatyping, erlend-aasland, gpshead, kumaraditya303, lysnikolaou, pablogsal and rhettinger as code owners April 16, 2026 20:41
clin1234 added 3 commits April 16, 2026 20:53
@clin1234
Spacing
eacf10a
@clin1234
Add asterisk
3def942
@clin1234
Format mimetypes addition for clarity
d815851
@clin1234
clin1234 force-pushed the patch-4 branch from 7d6da03 to d815851 Compare April 16, 2026 20:54
@freakboy3742
freakboy3742 removed their request for review April 16, 2026 22:37
@savannahostrowski
savannahostrowski removed their request for review April 17, 2026 15:12
@clin1234

clin1234 commented Apr 17, 2026

Copy link
Copy Markdown
Contributor Author

@StanFromIreland, @hugovk, @benediktjohannes, @encukou: would any one of you review #146344, #146342, and this? Finally got CI to not nag at me...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk removed request for a team, AA-Turner, FFY00, JelleZijlstra, ambv, berkerpeksag, emmatyping, erlend-aasland, gpshead, kumaraditya303, lysnikolaou, pablogsal, rhettinger and vsajip April 17, 2026 16:38
@clin1234
Merge branch 'main' into patch-4
590cb34
@clin1234

clin1234 commented May 4, 2026

Copy link
Copy Markdown
Contributor Author

Will this be merged in before beta1, and can this still be merged in during the beta releases?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk approved these changes May 4, 2026
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2026-03-13-14-23-33.gh-issue-145917.TooGKx.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented May 4, 2026

Copy link
Copy Markdown
Member

Yes, we can merge this before b1, just one suggestion to make the NEWS a bit shorter.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@read-the-docs-community

read-the-docs-community Bot commented May 4, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #32528752 | 📁 Comparing aecd96e against main (2faceee)

  🔍 Preview build  

105 files changed · + 1 added · ± 104 modified

+ Added

  • c-api/sentinel.html

± Modified

  • glossary.html
  • c-api/allocation.html
  • c-api/buffer.html
  • c-api/bytes.html
  • c-api/code.html
  • c-api/concrete.html
  • c-api/descriptor.html
  • c-api/exceptions.html
  • c-api/extension-modules.html
  • c-api/file.html
  • and 94 more...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@clin1234 @hugovk
Update Misc/NEWS.d/next/Library/2026-03-13-14-23-33.gh-issue-145917.T…
c0a5b36 
…ooGKx.rst

Co-authored-by: Hugo van Kemenade <[email protected]>
@hugovk

hugovk commented May 4, 2026

Copy link
Copy Markdown
Member

CI failure: I think the GH web editor has inserted the wrong CRLF line endings...

Please could you edit locally and replace with the usual LF?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@clin1234
CRLF -> LF
aecd96e
@hugovk

hugovk commented May 4, 2026

Copy link
Copy Markdown
Member

Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
+1 more reviewer
@benediktjohannes benediktjohannes benediktjohannes left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@clin1234 @benediktjohannes @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.