GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — gh-146341: Add new video MIME types to mimetypes.py by clin1234 · Pull Request #146342 · python/cpython Conversation
|
|
Please also like in the other PRs have a look on the checks and declare why failures are unrelated or fix them if not |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| - ``.pyv`` for ``video/vnd.ms-playready.media.pyv`` | ||
| - ``.blk`` and ``.bk2`` for ``video/vnd.radgamettools.bink`` | ||
| - ``.sswf`` and ``.ssw`` for ``video/vnd.sealed.swf`` | ||
| - ``.yt`` for ``video/vnd.youtube.yt`` |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Same as in other PR, maybe add your name here and please add 3.15 release notes and maybe combine the PRs
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Otherwise from short overview LGTM! Thank You for your effort!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Will this be merged in before beta1, and can this still be merged in during the beta releases? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Documentation build overview
463 files changed ·
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
You have conflicts, please fix them. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@benediktjohannes @hugovk @StanFromIreland, mind reviewing this PR again? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| John Franey | ||
| in :gh:`144217`, :gh:`145720`, :gh:`140937`, :gh:`139959`, :gh:`145698`, | ||
| :gh:`145718`, :gh:`145918`, and :gh:`144213`.) | ||
| :gh:`145718`, :gh:`146342`, :gh:`145918`, and :gh:`144213`.) |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
The 3.15 feature freeze has passed, please update for 3.16.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
| '.3gp' : 'video/3gpp', | ||
| '.3g2' : 'video/3gpp2', |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
We already have these earlier in the dict:
'.3gp' : 'audio/3gpp', ... '.3g2' : 'audio/3gpp2',
So these new video ones overwrite the audio ones.
Should we change it to the video ones, and remove the audio?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Well, they're both official MIME types: iana.org/assignments/media-types/audio/3gpp and iana.org/assignments/media-types/video/3gpp. The only major difference as far as I can tell is that the former cannot contain any visual data
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Interestingly, per the official 3GPP TS 26.244 V19.1.0 Specification:
The type "video/3gpp" is valid for all files. It is valid to serve an audio-only file as "video/3gpp".
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
And per this RFC: https://www.rfc-editor.org/info/rfc4393/#section-3.2
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
So, remove the audio
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@hugovk, when CI passes, can you review this? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Ping @hugovk @benediktjohannes |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.