GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||
GeezerVison is showing github.com — gh-131798: JIT: optimize _LOAD_COMMON_CONSTANT by trdthg · Pull Request #146104 · python/cpython Conversation
|
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this LGTM! Please remove the news entry, we don't need it as it's not a user facing code.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
068d2bb to
19fc90f
Compare
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
_LOAD_COMMON_CONSTANT x86_64 dissasembly in I think this is prior to our CFG optimizations in the backend, so it's not 100% accurate, but pretty close. _LOAD_CONST_INLINE_BORROW: This is a really nice reduction. Good job! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
19fc90f to
b37ec56
Compare
|
We generally don't force push, because all PRs in CPython are squash-merged. So just push normal commits, thanks! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Once again, LGTM. Thanks for this!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.