GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-146092: Handle _PyFrame_GetFrameObject() failures properly by vstinner · Pull Request #146124 · python/cpython

Conversation

vstinner commented Mar 18, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Fix _PyFrame_GetLocals() and _PyFrame_GetLocals() error handling.
_PyEval_ExceptionGroupMatch() now fails on _PyFrame_GetLocals() error.

Issue: Missing PyErr_NoMemory in _zoneinfo load_data and ts_to_local #146092

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-146092: Handle _PyFrame_GetFrameObject() failures properly

458277f

* Fix _PyFrame_GetLocals() and _PyFrame_GetLocals() error handling.
* _PyEval_ExceptionGroupMatch() now fails on _PyFrame_GetLocals()
  error.

vstinner requested a review from markshannon as a code owner

March 18, 2026 16:41

vstinner added skip news needs backport to 3.13

only security fixes

needs backport to 3.14 bugs and security fixes labels

Mar 18, 2026

bedevere-app Bot added the awaiting core review label

Mar 18, 2026

bedevere-app Bot mentioned this pull request

Mar 18, 2026

Missing PyErr_NoMemory in _zoneinfo load_data and ts_to_local #146092

Closed

kumaraditya303 approved these changes

Mar 18, 2026

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting core review labels

Mar 18, 2026

vstinner merged commit e1e4852 into python:main

Mar 18, 2026

67 checks passed

Uh oh!

There was an error while loading. Please reload this page.

vstinner deleted the frame_getlocals branch

March 18, 2026 17:27

miss-islington-app Bot commented Mar 18, 2026

Copy link

Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting merge label

Mar 18, 2026

miss-islington-app Bot commented Mar 18, 2026

Copy link

Copy Markdown

Sorry, @vstinner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e1e4852133ea548479bc9b975420a32331df7cee 3.14

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot assigned vstinner

Mar 18, 2026

vstinner commented Mar 18, 2026

Copy link

Copy Markdown

Member Author

PR merged. Thanks for your review @kumaraditya303.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot commented Mar 18, 2026

Copy link

Copy Markdown

Sorry, @vstinner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e1e4852133ea548479bc9b975420a32331df7cee 3.13

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner added a commit to vstinner/cpython that referenced this pull request

Mar 18, 2026


          pythongh-146092: Handle _PyFrame_GetFrameObject() failures properly (p…

5ec809b

…ython#146124)

* Fix _PyFrame_GetLocals() and _PyFrame_GetLocals() error handling.
* _PyEval_ExceptionGroupMatch() now fails on _PyFrame_GetLocals()
  error.

(cherry picked from commit e1e4852)

bedevere-app Bot commented Mar 18, 2026

Copy link

Copy Markdown

GH-146132 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label

Mar 18, 2026

vstinner removed the needs backport to 3.13 only security fixes label

Mar 18, 2026

vstinner added a commit that referenced this pull request

Mar 18, 2026


          [3.14] gh-146092: Handle _PyFrame_GetFrameObject() failures properly (#…

8eeb800

…146124) (#146132)

gh-146092: Handle _PyFrame_GetFrameObject() failures properly (#146124)

* Fix _PyFrame_GetLocals() and _PyFrame_GetLocals() error handling.
* _PyEval_ExceptionGroupMatch() now fails on _PyFrame_GetLocals()
  error.

(cherry picked from commit e1e4852)

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Mar 18, 2026


          [3.14] pythongh-146092: Handle _PyFrame_GetFrameObject() failures pro…

f785cb5

…perly (pythonGH-146124) (pythonGH-146132)

pythongh-146092: Handle _PyFrame_GetFrameObject() failures properly (pythonGH-146124)

* Fix _PyFrame_GetLocals() and _PyFrame_GetLocals() error handling.
* _PyEval_ExceptionGroupMatch() now fails on _PyFrame_GetLocals()
  error.
(cherry picked from commit 8eeb800)

Co-authored-by: Victor Stinner <[email protected]>
(cherry picked from commit e1e4852)

miss-islington mentioned this pull request

Mar 18, 2026

[3.13] gh-146092: Handle _PyFrame_GetFrameObject() failures properly (GH-146124) (GH-146132) #146138

Merged

vstinner added a commit that referenced this pull request

Mar 18, 2026


          [3.13] gh-146092: Handle _PyFrame_GetFrameObject() failures properly (G…

53b544a

…H-146124) (GH-146132) (#146138)

[3.14] gh-146092: Handle _PyFrame_GetFrameObject() failures properly (GH-146124) (GH-146132)

gh-146092: Handle _PyFrame_GetFrameObject() failures properly (GH-146124)

* Fix _PyFrame_GetLocals() and _PyFrame_GetLocals() error handling.
* _PyEval_ExceptionGroupMatch() now fails on _PyFrame_GetLocals()
  error.
(cherry picked from commit 8eeb800)


(cherry picked from commit e1e4852)

Co-authored-by: Victor Stinner <[email protected]>

pablogsal mentioned this pull request

Apr 4, 2026

gh-130273: Fix traceback color output with unicode characters #142529

Merged

ljfp pushed a commit to ljfp/cpython that referenced this pull request

Apr 25, 2026


          pythongh-146092: Handle _PyFrame_GetFrameObject() failures properly (p…

5fdfa41

…ython#146124)

* Fix _PyFrame_GetLocals() and _PyFrame_GetLocals() error handling.
* _PyEval_ExceptionGroupMatch() now fails on _PyFrame_GetLocals()
  error.

aisk mentioned this pull request

Jul 6, 2026

ceval.c: missing PyErr_NoMemory + PyEval_GetLocals NULL #153205

Closed

Reviewers

kumaraditya303

kumaraditya303 approved these changes

markshannon

Awaiting requested review from markshannon

markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

vstinner

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

vstinner commented Mar 18, 2026 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

miss-islington-app Bot commented Mar 18, 2026

Uh oh!

miss-islington-app Bot commented Mar 18, 2026

Uh oh!

vstinner commented Mar 18, 2026

Uh oh!

miss-islington-app Bot commented Mar 18, 2026

Uh oh!

bedevere-app Bot commented Mar 18, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vstinner commented Mar 18, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.