GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-145177: Put node version into emscripten/config.toml as well. by hoodmane · Pull Request #146156 · python/cpython

Conversation

hoodmane commented Mar 19, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

This is the last bit of config that is in the buildbot config that we should move to the cpython repo.

Issue: Emscripten buildbot: Support multiple Emscripten versions #145177

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-145177: Put node version into emscripten/config.toml as well.

f7b4182

This is the last bit of config that is in the buildbot config that we
should move to the cpython repo.

hoodmane added skip news OS-emscripten needs backport to 3.14 bugs and security fixes labels

Mar 19, 2026

bedevere-app Bot mentioned this pull request

Mar 19, 2026

Emscripten buildbot: Support multiple Emscripten versions #145177

Closed

bedevere-app Bot added the awaiting review label

Mar 19, 2026

hoodmane added 2 commits

March 19, 2026 09:35


          Remove unused default_host_runner variable

Fix

4f39165

hoodmane commented Mar 19, 2026

Copy link

Copy Markdown

Contributor Author

!buildbot emscripten

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented Mar 19, 2026

Copy link

Copy Markdown

🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 4f39165 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F146156%2Fmerge

The command will test the builders whose names match following regular expression: emscripten

The builders matched are:

WASM Emscripten PR

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hoodmane added a commit to hoodmane/buildmaster-config that referenced this pull request

Mar 19, 2026


          Improvements to the Emscripten buildbot

96780ff

* Use the build script from its new `Platform/emscripten/__main__.py` location
* Use `python3 Platform/emscripten run` to avoid hard coding build output path
* Use new `EMSDK_CACHE` environment variable to allow build script to manage
  Emscripten installations
* Allow build script to manage node installations

python/cpython#146156 has to land first

hoodmane mentioned this pull request

Mar 19, 2026

Improvements to the Emscripten buildbot python/buildmaster-config#687

Merged

freakboy3742 requested changes

Mar 19, 2026

View reviewed changes

freakboy3742 left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor tweak as an accomodation to those poor antipodean developers (cough... me) whose network connections are slow :-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Platforms/emscripten/__main__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Platforms/emscripten/__main__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting review label

Mar 19, 2026

bedevere-app Bot commented Mar 19, 2026

Copy link

Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot added the awaiting changes label

Mar 19, 2026

hoodmane added a commit to hoodmane/buildmaster-config that referenced this pull request

Mar 19, 2026


          Improvements to the Emscripten buildbot

d8ed65b

* Use the build script from its new `Platform/emscripten/__main__.py` location
* Use `python3 Platform/emscripten run` to avoid hard coding build output path
* Use new `EMSDK_CACHE` environment variable to allow build script to manage
  Emscripten installations
* Build libmpdec
* Cache libffi and libmpdec
* Allow build script to manage node installations

python/cpython#146156 has to land first


          Don't hide output from nvm install

d22facc

hoodmane commented Mar 19, 2026

Copy link

Copy Markdown

Contributor Author

Okay should be fixed now.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

freakboy3742 approved these changes

Mar 19, 2026

View reviewed changes

freakboy3742 left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting merge and removed awaiting changes labels

Mar 19, 2026

freakboy3742 enabled auto-merge (squash)

March 19, 2026 09:33

freakboy3742 merged commit 91e1312 into python:main

Mar 19, 2026

48 of 49 checks passed

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot commented Mar 19, 2026

Copy link

Copy Markdown

Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting merge label

Mar 19, 2026

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Mar 19, 2026


          pythongh-145177: Put node version into emscripten/config.toml. (pytho…

7f1d9c6

…nGH-146156)

Configure node version as part of the emscripten build script, and install
that node version if it isn't available.
(cherry picked from commit 91e1312)

Co-authored-by: Hood Chatham <[email protected]>

bedevere-app Bot commented Mar 19, 2026

Copy link

Copy Markdown

GH-146159 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label

Mar 19, 2026

hoodmane deleted the emscripten-node-version branch

March 19, 2026 09:38

freakboy3742 pushed a commit that referenced this pull request

Mar 19, 2026


          [3.14] gh-145177: Put node version into emscripten/config.toml. (GH-1…

0a9f397

…46156) (#146159)

Configure node version as part of the emscripten build script, and install
that node version if it isn't available.
(cherry picked from commit 91e1312)

Co-authored-by: Hood Chatham <[email protected]>

pablogsal mentioned this pull request

Apr 4, 2026

gh-130273: Fix traceback color output with unicode characters #142529

Merged

ljfp pushed a commit to ljfp/cpython that referenced this pull request

Apr 25, 2026


          pythongh-145177: Put node version into emscripten/config.toml. (pytho…

d297a90

…n#146156)

Configure node version as part of the emscripten build script, and install 
that node version if it isn't available.

Reviewers

freakboy3742

freakboy3742 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OS-emscripten skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

hoodmane commented Mar 19, 2026 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hoodmane commented Mar 19, 2026

Uh oh!

bedevere-bot commented Mar 19, 2026

Uh oh!

freakboy3742 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bedevere-app Bot commented Mar 19, 2026

Uh oh!

hoodmane commented Mar 19, 2026

Uh oh!

freakboy3742 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-app Bot commented Mar 19, 2026

Uh oh!

bedevere-app Bot commented Mar 19, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hoodmane commented Mar 19, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.